Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: use SNAPSHOT_SERDES to log snapshot ser/deserialization #49637

Merged
merged 2 commits into from
Sep 18, 2023
Merged

src: use SNAPSHOT_SERDES to log snapshot ser/deserialization #49637

merged 2 commits into from
Sep 18, 2023

Conversation

joyeecheung
Copy link
Member

To avoid clobbering output of MKSNAPSHOT

@joyeecheung
src: use SNAPSHOT_SERDES to log snapshot ser/deserialization
6be50bc 
To avoid clobbering output of MKSNAPSHOT
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2023
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Sep 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53927/

This was referenced Sep 14, 2023
Open
Open
@joyeecheung
Copy link
Member Author

@nodejs/startup @nodejs/cpp-reviewers Can I have some reviews please?

@joyeecheung
Copy link
Member Author

Ran clang-format to make linter happy..

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53966/

@github-actions github-actions bot mentioned this pull request Sep 16, 2023
Open
25 tasks
@github-actions github-actions bot mentioned this pull request Sep 17, 2023
Open
32 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54018/

@github-actions github-actions bot mentioned this pull request Sep 18, 2023
Open
33 tasks
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54026/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54032/

@joyeecheung joyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2023
@nodejs-github-bot nodejs-github-bot merged commit b03a757 into nodejs:main Sep 18, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in b03a757

This was referenced Sep 19, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@joyeecheung @ruyadorno
src: use SNAPSHOT_SERDES to log snapshot ser/deserialization
f611583 
To avoid clobbering output of MKSNAPSHOT

PR-URL: #49637
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@joyeecheung @alexfernandez
src: use SNAPSHOT_SERDES to log snapshot ser/deserialization
aebd533 
To avoid clobbering output of MKSNAPSHOT

PR-URL: nodejs#49637
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joyeecheung @nodejs-github-bot @jasnell @RaisinTen