-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
errors: improve performance of classRegExp in errors.js #49643
Conversation
Commit Queue failed- Loading data for nodejs/node/pull/49643 ✔ Done loading data for nodejs/node/pull/49643 ----------------------------------- PR info ------------------------------------ Title errors: improve performance of classRegExp in errors.js (#49643) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Uzlopak:improve-classRegExp -> nodejs:main Labels errors, author ready, needs-ci Commits 2 - errors: improve classRegExp in errors.js - fix linting issue Committers 1 - uzlopak PR-URL: https://github.com/nodejs/node/pull/49643 Reviewed-By: Yagiz Nizipli Reviewed-By: LiviaMedeiros Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49643 Reviewed-By: Yagiz Nizipli Reviewed-By: LiviaMedeiros Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 14 Sep 2023 01:06:38 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49643#pullrequestreview-1625778455 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/49643#pullrequestreview-1627548542 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49643#pullrequestreview-1627640362 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-09-14T18:44:30Z: https://ci.nodejs.org/job/node-test-pull-request/53951/ - Querying data for job/node-test-pull-request/53951/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 49643 From https://github.com/nodejs/node * branch refs/pull/49643/merge -> FETCH_HEAD ✔ Fetched commits as f42a1039917a..8a9e34c3f276 -------------------------------------------------------------------------------- Auto-merging lib/internal/errors.js [main 115c123fdb] errors: improve classRegExp in errors.js Author: uzlopak Date: Thu Sep 14 03:04:46 2023 +0200 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 benchmark/error/error-class-reg-exp.js [main e70bc66291] fix linting issue Author: uzlopak Date: Thu Sep 14 03:32:14 2023 +0200 1 file changed, 3 insertions(+), 3 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/6204361859 |
Landed in db8217b |
PR-URL: #49643 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#49643 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This PR simplifies the RegExp for detecting class names
Main:
error/error-class-reg-exp.js n=100000: 9,114.045930023383
PR:
error/error-class-reg-exp.js n=100000: 11,002.079862772853