stream: improve webstream readable async iterator performance #49662

rluvaton · 2023-09-15T11:32:53Z

140% Improvement

Benchmark CI

                                                                        confidence improvement accuracy (*)    (**)   (***)
 webstreams/creation.js kind='ReadableStream.tee' n=50000                              -0.96 %       ±3.01%  ±4.01%  ±5.22%
 webstreams/creation.js kind='ReadableStream' n=50000                                  -0.15 %       ±3.60%  ±4.79%  ±6.24%
 webstreams/creation.js kind='ReadableStreamBYOBReader' n=50000                        -0.26 %       ±4.59%  ±6.11%  ±7.95%
 webstreams/creation.js kind='ReadableStreamDefaultReader' n=50000                      6.40 %      ±10.81% ±14.40% ±18.76%
 webstreams/creation.js kind='TransformStream' n=50000                                 -1.70 %       ±2.61%  ±3.48%  ±4.52%
 webstreams/creation.js kind='WritableStream' n=50000                                   0.50 %       ±4.24%  ±5.65%  ±7.35%
 webstreams/pipe-to.js highWaterMarkW=1024 highWaterMarkR=1024 n=500000                 1.05 %       ±2.32%  ±3.09%  ±4.02%
 webstreams/pipe-to.js highWaterMarkW=1024 highWaterMarkR=2048 n=500000                -0.07 %       ±1.67%  ±2.23%  ±2.90%
 webstreams/pipe-to.js highWaterMarkW=1024 highWaterMarkR=4096 n=500000                 0.51 %       ±1.99%  ±2.66%  ±3.46%
 webstreams/pipe-to.js highWaterMarkW=1024 highWaterMarkR=512 n=500000                 -1.66 %       ±1.92%  ±2.56%  ±3.33%
 webstreams/pipe-to.js highWaterMarkW=2048 highWaterMarkR=1024 n=500000                 1.23 %       ±1.78%  ±2.37%  ±3.08%
 webstreams/pipe-to.js highWaterMarkW=2048 highWaterMarkR=2048 n=500000                -0.59 %       ±2.23%  ±2.97%  ±3.87%
 webstreams/pipe-to.js highWaterMarkW=2048 highWaterMarkR=4096 n=500000                 1.76 %       ±1.93%  ±2.57%  ±3.35%
 webstreams/pipe-to.js highWaterMarkW=2048 highWaterMarkR=512 n=500000                 -1.05 %       ±2.07%  ±2.76%  ±3.60%
 webstreams/pipe-to.js highWaterMarkW=4096 highWaterMarkR=1024 n=500000                -1.31 %       ±2.06%  ±2.74%  ±3.58%
 webstreams/pipe-to.js highWaterMarkW=4096 highWaterMarkR=2048 n=500000                 0.71 %       ±1.97%  ±2.62%  ±3.41%
 webstreams/pipe-to.js highWaterMarkW=4096 highWaterMarkR=4096 n=500000                 1.58 %       ±1.68%  ±2.24%  ±2.91%
 webstreams/pipe-to.js highWaterMarkW=4096 highWaterMarkR=512 n=500000                 -1.58 %       ±2.00%  ±2.66%  ±3.46%
 webstreams/pipe-to.js highWaterMarkW=512 highWaterMarkR=1024 n=500000                 -1.08 %       ±2.10%  ±2.79%  ±3.64%
 webstreams/pipe-to.js highWaterMarkW=512 highWaterMarkR=2048 n=500000                 -1.20 %       ±2.05%  ±2.72%  ±3.54%
 webstreams/pipe-to.js highWaterMarkW=512 highWaterMarkR=4096 n=500000                 -0.27 %       ±2.23%  ±2.97%  ±3.87%
 webstreams/pipe-to.js highWaterMarkW=512 highWaterMarkR=512 n=500000                   1.03 %       ±2.07%  ±2.75%  ±3.58%
 webstreams/readable-async-iterator.js n=100000                                ***    140.34 %      ±13.76% ±18.45% ±24.31%
 
 Be aware that when doing many comparisons the risk of a false-positive
 result increases. In this case, there are 23 comparisons, you can thus
 expect the following amount of false-positive results:
   1.15 false positives, when considering a   5% risk acceptance (*, **, ***),
   0.23 false positives, when considering a   1% risk acceptance (**, ***),
   0.02 false positives, when considering a 0.1% risk acceptance (***)

My local tests

confidence improvement accuracy (*)   (**)  (***)
webstreams/readable-async-iterator.js n=100000                                ***    136.22 %       ±1.83% ±2.45% ±3.24%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 23 comparisons, you can thus expect the following amount of false-positive results:
  1.15 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.23 false positives, when considering a   1% risk acceptance (**, ***),
  0.02 false positives, when considering a 0.1% risk acceptance (***)

rluvaton · 2023-09-15T11:34:15Z

Benchmark CI (currently 404 as it's in a queue):
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1388/

nodejs-github-bot · 2023-09-15T12:38:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53963/

nodejs-github-bot · 2023-09-15T14:16:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53967/

mcollina

lgtm

lib/internal/webstreams/readablestream.js

Co-authored-by: Benjamin Gruenbaum <inglor@gmail.com>

nodejs-github-bot · 2023-09-17T18:27:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54009/

nodejs-github-bot · 2023-09-17T19:40:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54012/

nodejs-github-bot · 2023-09-18T13:56:04Z

Commit Queue failed

- Loading data for nodejs/node/pull/49662 ✔ Done loading data for nodejs/node/pull/49662 ----------------------------------- PR info ------------------------------------ Title stream: improve webstream readable async iterator performance (#49662) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch rluvaton:improve-readable-stream-async-iterator -> nodejs:main Labels performance, author ready, needs-ci, needs-benchmark-ci, web streams Commits 5 - stream: improve webstream readable async iterator performance - stream: rename, fix lint issues and cleanup - stream: add proto - stream: inline var - stream: remove `__proto__: null` due to performance hit Committers 2 - Raz Luvaton <16746759+rluvaton@users.noreply.github.com> - GitHub PR-URL: https://github.com/nodejs/node/pull/49662 Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49662 Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 15 Sep 2023 11:32:53 GMT ✔ Approvals: 6 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49662#pullrequestreview-1629143084 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49662#pullrequestreview-1629556395 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49662#pullrequestreview-1629701561 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/49662#pullrequestreview-1629983394 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49662#pullrequestreview-1630072844 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49662#pullrequestreview-1631104311 ✔ Last GitHub CI successful ℹ Last Benchmark CI on 2023-09-18T13:22:25Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1388/ ℹ Last Full PR CI on 2023-09-18T13:22:25Z: https://ci.nodejs.org/job/node-test-pull-request/54033/ - Querying data for job/node-test-pull-request/1388/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 49662 From https://github.com/nodejs/node * branch refs/pull/49662/merge -> FETCH_HEAD ✔ Fetched commits as b03a757619db..824abd622d65 -------------------------------------------------------------------------------- [main 9e5b3a7ed2] stream: improve webstream readable async iterator performance Author: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Fri Sep 15 14:32:31 2023 +0300 1 file changed, 46 insertions(+), 29 deletions(-) [main 2419b69e63] stream: rename, fix lint issues and cleanup Author: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Fri Sep 15 14:39:30 2023 +0300 1 file changed, 32 insertions(+), 33 deletions(-) [main bb9ba7cb76] stream: add proto Author: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Sun Sep 17 19:38:11 2023 +0300 1 file changed, 1 insertion(+) [main a31438954c] stream: inline var Author: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Sun Sep 17 22:58:17 2023 +0300 1 file changed, 1 insertion(+), 3 deletions(-) [main cf191602a9] stream: remove `__proto__: null` due to performance hit Author: Raz Luvaton <16746759+rluvaton@users.noreply.github.com> Date: Mon Sep 18 10:20:13 2023 +0300 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 5 commits in the PR. Attempting autorebase. Rebasing (2/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: improve webstream readable async iterator performance

PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il

[detached HEAD 1c9a3f84a2] stream: improve webstream readable async iterator performance
Author: Raz Luvaton 16746759+rluvaton@users.noreply.github.com
Date: Fri Sep 15 14:32:31 2023 +0300
1 file changed, 46 insertions(+), 29 deletions(-)
Rebasing (3/10)
Rebasing (4/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: rename, fix lint issues and cleanup

PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il

[detached HEAD fb2af515cb] stream: rename, fix lint issues and cleanup
Author: Raz Luvaton 16746759+rluvaton@users.noreply.github.com
Date: Fri Sep 15 14:39:30 2023 +0300
1 file changed, 32 insertions(+), 33 deletions(-)
Rebasing (5/10)
Rebasing (6/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: add proto

Co-authored-by: Benjamin Gruenbaum inglor@gmail.com
PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il

[detached HEAD 4b57b45213] stream: add proto
Author: Raz Luvaton 16746759+rluvaton@users.noreply.github.com
Date: Sun Sep 17 19:38:11 2023 +0300
1 file changed, 1 insertion(+)
Rebasing (7/10)
Rebasing (8/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: inline var

PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il

[detached HEAD 9123089652] stream: inline var
Author: Raz Luvaton 16746759+rluvaton@users.noreply.github.com
Date: Sun Sep 17 22:58:17 2023 +0300
1 file changed, 1 insertion(+), 3 deletions(-)
Rebasing (9/10)
Rebasing (10/10)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
stream: remove __proto__: null due to performance hit

from 140% improvement to 120%

PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il

[detached HEAD d515c67265] stream: remove __proto__: null due to performance hit
Author: Raz Luvaton 16746759+rluvaton@users.noreply.github.com
Date: Mon Sep 18 10:20:13 2023 +0300
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6223523578

nodejs-github-bot · 2023-09-18T14:17:41Z

Landed in 5c39ee6

anonrig · 2023-09-18T19:08:31Z

I believe this pull request deserves the notable change label.

github-actions · 2023-09-18T19:08:35Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment.

PR-URL: #49662 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Notable changes: doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49683 * promote fetch/webstreams from experimental to stable (Steven) #45684 * deprecate `util.toUSVString` (Yagiz Nizipli) #49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) #49647 esm: * set all hooks as release candidate (Geoffrey Booth) #49597 stream: * use bitmap in writable state (Raz Luvaton) #49834 * use bitmap in readable state (Benjamin Gruenbaum) #49745 * improve webstream readable async iterator performance (Raz Luvaton) #49662 PR-URL: TODO

Notable changes: doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49683 * promote fetch/webstreams from experimental to stable (Steven) #45684 * deprecate `util.toUSVString` (Yagiz Nizipli) #49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) #49647 esm: * set all hooks as release candidate (Geoffrey Booth) #49597 stream: * use bitmap in writable state (Raz Luvaton) #49834 * use bitmap in readable state (Benjamin Gruenbaum) #49745 * improve webstream readable async iterator performance (Raz Luvaton) #49662 PR-URL: #49917

Notable changes: doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49683 * deprecate `util.toUSVString` (Yagiz Nizipli) #49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) #49647 esm: * set all hooks as release candidate (Geoffrey Booth) #49597 src: * (SEMVER-MINOR) allow embedders to override NODE_MODULE_VERSION (Cheng Zhao) #49279 stream: * use bitmap in writable state (Raz Luvaton) #49834 * use bitmap in readable state (Benjamin Gruenbaum) #49745 * improve webstream readable async iterator performance (Raz Luvaton) #49662 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) #49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) #49614 PR-URL: TODO

Notable changes: deps: * add v8::Object::SetInternalFieldForNodeCore() (Joyee Cheung) #49874 doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49683 * deprecate `util.toUSVString` (Yagiz Nizipli) #49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) #49647 esm: * set all hooks as release candidate (Geoffrey Booth) #49597 module: * fix the leak in SourceTextModule and ContextifySript (Joyee Cheung) #48510 * fix leak of vm.SyntheticModule (Joyee Cheung) #48510 * use symbol in WeakMap to manage host defined options (Joyee Cheung) #48510 src: * (SEMVER-MINOR) allow embedders to override NODE_MODULE_VERSION (Cheng Zhao) #49279 stream: * use bitmap in writable state (Raz Luvaton) #49834 * use bitmap in readable state (Benjamin Gruenbaum) #49745 * improve webstream readable async iterator performance (Raz Luvaton) #49662 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) #49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) #49614 PR-URL: #49932

PR-URL: nodejs#49662 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Notable changes: deps: * add v8::Object::SetInternalFieldForNodeCore() (Joyee Cheung) nodejs#49874 doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) nodejs#49683 * deprecate `util.toUSVString` (Yagiz Nizipli) nodejs#49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) nodejs#49647 esm: * set all hooks as release candidate (Geoffrey Booth) nodejs#49597 module: * fix the leak in SourceTextModule and ContextifySript (Joyee Cheung) nodejs#48510 * fix leak of vm.SyntheticModule (Joyee Cheung) nodejs#48510 * use symbol in WeakMap to manage host defined options (Joyee Cheung) nodejs#48510 src: * (SEMVER-MINOR) allow embedders to override NODE_MODULE_VERSION (Cheng Zhao) nodejs#49279 stream: * use bitmap in writable state (Raz Luvaton) nodejs#49834 * use bitmap in readable state (Benjamin Gruenbaum) nodejs#49745 * improve webstream readable async iterator performance (Raz Luvaton) nodejs#49662 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) nodejs#49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) nodejs#49614 PR-URL: nodejs#49932

stream: improve webstream readable async iterator performance

8a21c2e

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Sep 15, 2023

rluvaton added needs-benchmark-ci PR that need a benchmark CI run. performance Issues and PRs related to the performance of Node.js. labels Sep 15, 2023

rluvaton marked this pull request as ready for review September 15, 2023 11:35

stream: rename, fix lint issues and cleanup

2c62bf6

rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2023

mcollina approved these changes Sep 15, 2023

View reviewed changes

lpinca approved these changes Sep 15, 2023

View reviewed changes

anonrig approved these changes Sep 15, 2023

View reviewed changes

github-actions bot mentioned this pull request Sep 16, 2023

CI Reliability 2023-09-16 nodejs/reliability#667

Open

25 tasks

jasnell approved these changes Sep 16, 2023

View reviewed changes

github-actions bot mentioned this pull request Sep 17, 2023

CI Reliability 2023-09-17 nodejs/reliability#668

Open

32 tasks

benjamingr reviewed Sep 17, 2023

View reviewed changes

lib/internal/webstreams/readablestream.js Show resolved Hide resolved

benjamingr reviewed Sep 17, 2023

View reviewed changes

lib/internal/webstreams/readablestream.js Show resolved Hide resolved

benjamingr approved these changes Sep 17, 2023

View reviewed changes

stream: add proto

066330b

Co-authored-by: Benjamin Gruenbaum <inglor@gmail.com>

rluvaton added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 17, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2023

stream: inline var

7f423eb

rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2023

rluvaton added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 18, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 18, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2023

nodejs-github-bot merged commit 5c39ee6 into nodejs:main Sep 18, 2023

rluvaton deleted the improve-readable-stream-async-iterator branch September 18, 2023 14:19

anonrig added the notable-change PRs with changes that should be highlighted in changelogs. label Sep 18, 2023

This was referenced Sep 19, 2023

CI Reliability 2023-09-19 nodejs/reliability#670

Open

CI Reliability 2023-09-20 nodejs/reliability#671

Open

CI Reliability 2023-09-21 nodejs/reliability#672

Open

ruyadorno mentioned this pull request Sep 28, 2023

v20.7.1 proposal #49917

Closed

ruyadorno mentioned this pull request Sep 28, 2023

v20.8.0 proposal #49932

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stream: improve webstream readable async iterator performance #49662

stream: improve webstream readable async iterator performance #49662

rluvaton commented Sep 15, 2023 •

edited

Loading

rluvaton commented Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

mcollina left a comment

nodejs-github-bot commented Sep 17, 2023

nodejs-github-bot commented Sep 17, 2023

nodejs-github-bot commented Sep 18, 2023

PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il

PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il

PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il

PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Sep 18, 2023

anonrig commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

stream: improve webstream readable async iterator performance #49662

stream: improve webstream readable async iterator performance #49662

Conversation

rluvaton commented Sep 15, 2023 • edited Loading

Benchmark CI

My local tests

rluvaton commented Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Sep 17, 2023

nodejs-github-bot commented Sep 17, 2023

nodejs-github-bot commented Sep 18, 2023

PR-URL: #49662 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: Moshe Atlow moshe@atlow.co.il

PR-URL: #49662 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: Moshe Atlow moshe@atlow.co.il

PR-URL: #49662 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: Moshe Atlow moshe@atlow.co.il

PR-URL: #49662 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: Moshe Atlow moshe@atlow.co.il

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Sep 18, 2023

anonrig commented Sep 18, 2023

github-actions bot commented Sep 18, 2023

rluvaton commented Sep 15, 2023 •

edited

Loading

PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il

PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il

PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il

PR-URL: #49662
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il