Skip to content

deps: backport --predictable related changes to V8 #49703

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

deps: backport --predictable related changes to V8 #49703

wants to merge 2 commits into from

Conversation

joyeecheung
Copy link
Member

deps: V8: cherry-pick b33bf2dfd261

Original commit message:

Ignore --predictable when computing flag list hashes

This allows reproducible code cache generation.

Refs: https://github.com/nodejs/node/pull/48749

Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#88943}

Refs: v8/v8@b33bf2d

deps: V8: backport de9a5de2274f

Original commit message:

Ignore flags implied by --predictable during hash computation

https://chromium-review.googlesource.com/c/v8/v8/+/4681766 added
code to ignore --predictable during hash computation of flags
in order to produce reproducible code cache. This turns out to
be not enough since the flags implied by --predictable also
need to be ignored for it to work. This patch makes sure that
they are ignored.

Change-Id: Ifa36641efe3ca105706fd293be46fc974055d2d4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4851287
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Patrick Thier <pthier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#90022}

Refs: v8/v8@de9a5de

@joyeecheung
deps: V8: cherry-pick b33bf2dfd261
8f4e632 
Original commit message:

    Ignore --predictable when computing flag list hashes

    This allows reproducible code cache generation.

    Refs: nodejs#48749

    Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#88943}

Refs: v8/v8@b33bf2d
@joyeecheung
deps: V8: backport de9a5de2274f
308af9f 
Original commit message:

    Ignore flags implied by --predictable during hash computation

    https://chromium-review.googlesource.com/c/v8/v8/+/4681766 added
    code to ignore --predictable during hash computation of flags
    in order to produce reproducible code cache. This turns out to
    be not enough since the flags implied by --predictable also
    need to be ignored for it to work. This patch makes sure that
    they are ignored.

    Change-Id: Ifa36641efe3ca105706fd293be46fc974055d2d4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4851287
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#90022}

Refs: v8/v8@de9a5de
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 18, 2023
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5574/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5574/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5574/

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54152/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5580/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5580/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5580/

This was referenced Sep 23, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54207/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54209/

@richardlau richardlau added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 1716769...c1dfaea

nodejs-github-bot pushed a commit that referenced this pull request Sep 25, 2023
@joyeecheung @nodejs-github-bot
deps: V8: cherry-pick b33bf2dfd261
e074512 
Original commit message:

    Ignore --predictable when computing flag list hashes

    This allows reproducible code cache generation.

    Refs: #48749

    Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#88943}

Refs: v8/v8@b33bf2d
PR-URL: #49703
Refs: v8/v8@de9a5de
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit that referenced this pull request Sep 25, 2023
@joyeecheung @nodejs-github-bot
deps: V8: backport de9a5de2274f
c1dfaea 
Original commit message:

    Ignore flags implied by --predictable during hash computation

    https://chromium-review.googlesource.com/c/v8/v8/+/4681766 added
    code to ignore --predictable during hash computation of flags
    in order to produce reproducible code cache. This turns out to
    be not enough since the flags implied by --predictable also
    need to be ignored for it to work. This patch makes sure that
    they are ignored.

    Change-Id: Ifa36641efe3ca105706fd293be46fc974055d2d4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4851287
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#90022}

Refs: v8/v8@de9a5de
PR-URL: #49703
Refs: v8/v8@b33bf2d
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@richardlau richardlau mentioned this pull request Sep 25, 2023
Merged
@joyeecheung joyeecheung mentioned this pull request Sep 26, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@joyeecheung @ruyadorno
deps: V8: cherry-pick b33bf2dfd261
1f16df2 
Original commit message:

    Ignore --predictable when computing flag list hashes

    This allows reproducible code cache generation.

    Refs: #48749

    Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#88943}

Refs: v8/v8@b33bf2d
PR-URL: #49703
Refs: v8/v8@de9a5de
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@joyeecheung @ruyadorno
deps: V8: backport de9a5de2274f
aea7371 
Original commit message:

    Ignore flags implied by --predictable during hash computation

    https://chromium-review.googlesource.com/c/v8/v8/+/4681766 added
    code to ignore --predictable during hash computation of flags
    in order to produce reproducible code cache. This turns out to
    be not enough since the flags implied by --predictable also
    need to be ignored for it to work. This patch makes sure that
    they are ignored.

    Change-Id: Ifa36641efe3ca105706fd293be46fc974055d2d4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4851287
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#90022}

Refs: v8/v8@de9a5de
PR-URL: #49703
Refs: v8/v8@b33bf2d
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@joyeecheung @ruyadorno
deps: V8: cherry-pick b33bf2dfd261
cdd1c66 
Original commit message:

    Ignore --predictable when computing flag list hashes

    This allows reproducible code cache generation.

    Refs: #48749

    Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#88943}

Refs: v8/v8@b33bf2d
PR-URL: #49703
Refs: v8/v8@de9a5de
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@joyeecheung @ruyadorno
deps: V8: backport de9a5de2274f
ad37cad 
Original commit message:

    Ignore flags implied by --predictable during hash computation

    https://chromium-review.googlesource.com/c/v8/v8/+/4681766 added
    code to ignore --predictable during hash computation of flags
    in order to produce reproducible code cache. This turns out to
    be not enough since the flags implied by --predictable also
    need to be ignored for it to work. This patch makes sure that
    they are ignored.

    Change-Id: Ifa36641efe3ca105706fd293be46fc974055d2d4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4851287
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#90022}

Refs: v8/v8@de9a5de
PR-URL: #49703
Refs: v8/v8@b33bf2d
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@joyeecheung @alexfernandez
deps: V8: cherry-pick b33bf2dfd261
36d7f25 
Original commit message:

    Ignore --predictable when computing flag list hashes

    This allows reproducible code cache generation.

    Refs: nodejs#48749

    Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#88943}

Refs: v8/v8@b33bf2d
PR-URL: nodejs#49703
Refs: v8/v8@de9a5de
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@joyeecheung @alexfernandez
deps: V8: backport de9a5de2274f
82980ba 
Original commit message:

    Ignore flags implied by --predictable during hash computation

    https://chromium-review.googlesource.com/c/v8/v8/+/4681766 added
    code to ignore --predictable during hash computation of flags
    in order to produce reproducible code cache. This turns out to
    be not enough since the flags implied by --predictable also
    need to be ignored for it to work. This patch makes sure that
    they are ignored.

    Change-Id: Ifa36641efe3ca105706fd293be46fc974055d2d4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4851287
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#90022}

Refs: v8/v8@de9a5de
PR-URL: nodejs#49703
Refs: v8/v8@b33bf2d
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos mentioned this pull request Dec 21, 2023
Merged
richardlau added a commit to richardlau/node-1 that referenced this pull request Mar 28, 2024
@richardlau
deps: V8: remove references to non-existent flags
15291e7 
nodejs#49703 cherry-picked a commit from
upstream V8 which references some maglev-related flags that are not
present in the version of V8 in Node.js 20.
@richardlau richardlau mentioned this pull request Mar 28, 2024
Closed
richardlau added a commit to richardlau/node-1 that referenced this pull request Apr 10, 2024
@richardlau
deps: V8: remove references to non-existent flags
eb7d9b7 
nodejs#49703 cherry-picked a commit from
upstream V8 which references some maglev-related flags that are not
present in the version of V8 in Node.js 20.
richardlau added a commit that referenced this pull request Apr 17, 2024
@richardlau
deps: V8: remove references to non-existent flags
ecadd63 
#49703 cherry-picked a commit from
upstream V8 which references some maglev-related flags that are not
present in the version of V8 in Node.js 20.

PR-URL: #52256
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@targos targos targos approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyeecheung @nodejs-github-bot @targos @gengjiawen @richardlau