Skip to content

test: replace foreach with for in test-https-simple.js #49793

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Shikha2410
Copy link

@Shikha2410 Shikha2410 commented Sep 22, 2023

Fixes: #50818

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 22, 2023
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend the commit message and force-push as described here. The prefix should be test:, not core:.

@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 22, 2023
@Shikha2410 Shikha2410 changed the title core: replace foreach with for in test-https-simple.js test: replace foreach with for in test-https-simple.js Sep 22, 2023
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2023
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Shikha2410! And apologies about the delay.

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@Shikha2410
Copy link
Author

Thank you for approving @tniessen. Anything I can do to help resolve the build failures in CI?

@MrJithil
Copy link
Member

I had triggered a re-run for the failed actions.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49793
✔  Done loading data for nodejs/node/pull/49793
----------------------------------- PR info ------------------------------------
Title      test: replace foreach with for in test-https-simple.js (#49793)
Author     Shikha Mehta  (@Shikha2410, first-time contributor)
Branch     Shikha2410:replace-foreach -> nodejs:main
Labels     test, code-and-learn, author ready, needs-ci
Commits    1
 - test: replace foreach with for in test-https-simple.js
Committers 1
 - Shikha Mehta 
PR-URL: https://github.com/nodejs/node/pull/49793
Fixes: https://docs.google.com/spreadsheets/d/1kjaxxXX2zGgJUoqj-7U3EYf_0dvSuI-N6YPan4Hye_4/edit#gid=0&range=100:100
Reviewed-By: Tobias Nießen 
Reviewed-By: Jithil P Ponnan 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49793
Fixes: https://docs.google.com/spreadsheets/d/1kjaxxXX2zGgJUoqj-7U3EYf_0dvSuI-N6YPan4Hye_4/edit#gid=0&range=100:100
Reviewed-By: Tobias Nießen 
Reviewed-By: Jithil P Ponnan 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 22 Sep 2023 22:40:08 GMT
   ✔  Approvals: 2
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49793#pullrequestreview-1739958150
   ✔  - Jithil P Ponnan (@MrJithil): https://github.com/nodejs/node/pull/49793#pullrequestreview-1741332180
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-11-21T13:00:20Z: https://ci.nodejs.org/job/node-test-pull-request/55823/
- Querying data for job/node-test-pull-request/55823/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 49793
From https://github.com/nodejs/node
 * branch                  refs/pull/49793/merge -> FETCH_HEAD
✔  Fetched commits as 1858341377c2..cc7938d71ac5
--------------------------------------------------------------------------------
[main 95eeeaaf91] test: replace foreach with for in test-https-simple.js
 Author: Shikha Mehta 
 Date: Fri Sep 22 15:22:18 2023 -0700
 1 file changed, 2 insertions(+), 2 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
test: replace foreach with for in test-https-simple.js

Fixes: #50818
PR-URL: #49793
Fixes: https://docs.google.com/spreadsheets/d/1kjaxxXX2zGgJUoqj-7U3EYf_0dvSuI-N6YPan4Hye_4/edit#gid=0&range=100:100
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Jithil P Ponnan jithil@outlook.com

[main 23d682ade1] test: replace foreach with for in test-https-simple.js
Author: Shikha Mehta shikha.mehta@ufl.edu
Date: Fri Sep 22 15:22:18 2023 -0700
1 file changed, 2 insertions(+), 2 deletions(-)
✖ 23d682ade1e7b5fc3f4744013eb8c2e971ed2053
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 1:7 Valid fixes URL. fixes-url
✖ 3:7 Fixes must be a GitHub URL. fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 2:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
⚠ 0:50 Title should be <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/6950894323

@tniessen tniessen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit 4e713a3 into nodejs:main Nov 23, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 4e713a3

martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
Fixes: nodejs#50818
PR-URL: nodejs#49793
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
Fixes: nodejs#50818
PR-URL: nodejs#49793
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
Fixes: #50818
PR-URL: #49793
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: replace foreach with for in test-https-simple.js
4 participants