Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: replace forEach with for..of in test-fs-realpath-buffer-encoding #49804

Closed
wants to merge 3 commits into from
Closed

test: replace forEach with for..of in test-fs-realpath-buffer-encoding #49804

wants to merge 3 commits into from

Conversation

niyashiyas
Copy link
Contributor

@niyashiyas niyashiyas commented Sep 23, 2023 •
edited
Loading

Replaced forEach with for..of in test-fs-realpath-buffer-encoding.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 23, 2023
@niyashiyas
Copy link
Contributor Author

Changed file test-fs-realpath-buffer-encoding.js

@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 23, 2023
@niyashiyas
Copy link
Contributor Author

I've made the required changes. Please review again.

@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54212/

This was referenced Sep 27, 2023
Open
Open
@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55081/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49804
✔  Done loading data for nodejs/node/pull/49804
----------------------------------- PR info ------------------------------------
Title      test: replace forEach with  for..of in test-fs-realpath-buffer-encoding (#49804)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     niyashiyas:test-fs-realpath -> nodejs:main
Labels     test, code-and-learn, needs-ci, commit-queue-squash
Commits    3
 - test: replace forEach with for..of in test-fs-realpath-buffer-encoding
 - test: replace forEach with for..of in test-fs-readv.js
 - test: replace forEach with for..of in test-fs-realpath-buffer-encoding
Committers 1
 - Niya Shiyas 
PR-URL: https://github.com/nodejs/node/pull/49804
Reviewed-By: Trivikram Kamat 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49804
Reviewed-By: Trivikram Kamat 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - test: replace forEach with for..of in test-fs-realpath-buffer-encoding
   ⚠  - test: replace forEach with for..of in test-fs-readv.js
   ⚠  - test: replace forEach with for..of in test-fs-realpath-buffer-encoding
   ℹ  This PR was created on Sat, 23 Sep 2023 06:14:31 GMT
   ✔  Approvals: 2
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/49804#pullrequestreview-1641281338
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49804#pullrequestreview-1642000311
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-10-21T04:56:27Z: https://ci.nodejs.org/job/node-test-pull-request/55081/
- Querying data for job/node-test-pull-request/55081/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6597965086

lpinca pushed a commit that referenced this pull request Nov 2, 2023
@niyashiyas @lpinca
test: replace forEach with for...of in test-fs-realpath-buffer-encoding
a1693c6 
PR-URL: #49804
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca
Copy link
Member

lpinca commented Nov 2, 2023

Landed in a1693c6.

@lpinca lpinca closed this Nov 2, 2023
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
@niyashiyas @anonrig
test: replace forEach with for...of in test-fs-realpath-buffer-encoding
fa8f0dd 
PR-URL: nodejs#49804
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@niyashiyas @targos
test: replace forEach with for...of in test-fs-realpath-buffer-encoding
6868d4e 
PR-URL: #49804
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@niyashiyas @targos
test: replace forEach with for...of in test-fs-realpath-buffer-encoding
d24de12 
PR-URL: #49804
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@niyashiyas @UlisesGascon
test: replace forEach with for...of in test-fs-realpath-buffer-encoding
9dc63c5 
PR-URL: #49804
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@tniessen tniessen tniessen approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@niyashiyas @nodejs-github-bot @lpinca @jasnell @tniessen @trivikr @ZYSzys