test: test-node-output-v8-warning.mjs fails alphanumeric fixture paths #50730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
MrJithil
changed the title
MrJithil
changed the title
test-node-output-v8-warning.mjs fails alphanumeric fixture paths
MrJithil
changed the title
test-node-output-v8-warning.mjs fails alphanumeric fixture paths
MoLow
approved these changes
Nov 15, 2023
H4ad
approved these changes
Nov 15, 2023
MrJithil
added
author ready
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
|
@targos If we are good to go, I can land this. Please let me know your review. |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Merged
RafaelGSS
approved these changes
Nov 28, 2023
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50730 ✔ Done loading data for nodejs/node/pull/50730 ----------------------------------- PR info ------------------------------------ Title test: test-node-output-v8-warning.mjs fails alphanumeric fixture paths (#50730) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MrJithil:fix-50724 -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: fix message v8 not normalising alphanumeric paths Committers 1 - Jithil P Ponnan PR-URL: https://github.com/nodejs/node/pull/50730 Fixes: https://github.com/nodejs/node/issues/50724 Reviewed-By: Moshe Atlow Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50730 Fixes: https://github.com/nodejs/node/issues/50724 Reviewed-By: Moshe Atlow Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Rafael Gonzaga -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 14 Nov 2023 13:53:28 GMT ✔ Approvals: 3 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/50730#pullrequestreview-1731646441 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50730#pullrequestreview-1732140211 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/50730#pullrequestreview-1753722281 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-11-28T14:12:07Z: https://ci.nodejs.org/job/node-test-pull-request/55977/ - Querying data for job/node-test-pull-request/55977/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7023555020 |
|
Landed in 3f10a21 |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #50724
test-node-output-v8-warning.mjsfails alphanumeric fixture paths like_temp/node-v21.2.0-nightly2023-11-12ff7dd9c2ca, it will not properly
get normalised
as a temporary fix we can remove all the string before the fixture
path