Skip to content

benchmark: update iterations in benchmark/util/inspect-array.js #50933

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2023
Merged

benchmark: update iterations in benchmark/util/inspect-array.js #50933

merged 1 commit into from
Dec 4, 2023

Conversation

lucshi
Copy link

@lucshi lucshi commented Nov 27, 2023 •
edited by H4ad
Loading

Refs: #50571

Belowing are the score improvement after 10X iteration change:

util/inspect-array.js n=5000
util/inspect-array.js type="denseArray"  n=5000 percent=159.84%
util/inspect-array.js type="sparseArray"  n=5000 percent=245.72%
util/inspect-array.js type="denseArray_showHidden"  n=5000 percent=158.26%
util/inspect-array.js type="denseArray"  n=5000 percent=164.69%
util/inspect-array.js type="denseArray_showHidden"  n=5000 percent=158.53%

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module. labels Nov 27, 2023
@H4ad H4ad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2023
@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2023
@nodejs-github-bot nodejs-github-bot merged commit 964046d into nodejs:main Dec 4, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 964046d

@H4ad
Copy link
Member

H4ad commented Dec 4, 2023

@UlisesGascon do you know why your email was not included in the commit as reviewer?

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@RafaelGSS
benchmark: update iterations in benchmark/util/inspect-array.js
dbee03d 
Fixes: #50571
PR-URL: #50933
Refs: #50571
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@richardlau
benchmark: update iterations in benchmark/util/inspect-array.js
4fc83e1 
Fixes: #50571
PR-URL: #50933
Refs: #50571
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@H4ad H4ad H4ad approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucshi @nodejs-github-bot @H4ad @UlisesGascon