Skip to content

doc: add deprecation notice to dirent.path #51059

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2023
Merged

doc: add deprecation notice to dirent.path #51059

merged 1 commit into from
Dec 5, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 5, 2023

Looks like we forgot about updating fs.md when working on #51020

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 5, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Dec 5, 2023
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2023
@aduh95 aduh95 mentioned this pull request Dec 5, 2023
Merged
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit a49b77b into nodejs:main Dec 5, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in a49b77b

@aduh95 aduh95 deleted the dirent-path-deprecation- branch December 5, 2023 21:17
aduh95 added a commit to aduh95/node that referenced this pull request Dec 5, 2023
@aduh95
doc: add deprecation notice to dirent.path
99ac462 
Refs: nodejs#51020
PR-URL: nodejs#51059
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@aduh95 @RafaelGSS
doc: add deprecation notice to dirent.path
c45a9a3 
Refs: #51020
PR-URL: #51059
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 18, 2024
@aduh95 @richardlau
doc: add deprecation notice to dirent.path
194ff6a 
Refs: #51020
PR-URL: #51059
Backport-PR-URL: #51021
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #50976
@richardlau richardlau added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Mar 18, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@aduh95 @richardlau
doc: add deprecation notice to dirent.path
09ad974 
Refs: #51020
PR-URL: #51059
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

@debadree25 debadree25 debadree25 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @lpinca @MoLow @debadree25 @richardlau