lib: reduce overhead of SafePromiseAllSettledReturnVoid calls
#51243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was simply calling `SafePromiseAllSettled`, which itself calls `arrayToSafePromiseIterable` which wraps all promises into new `SafePromise` object and wraps it into a `SafeArrayIterator`. Since we don't care about the return value, we can take some shortcuts.
targos
approved these changes
Dec 21, 2023
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
H4ad
approved these changes
Dec 21, 2023
H4ad
reviewed
Dec 21, 2023
aduh95
added
the
commit-queue
jasnell
approved these changes
Dec 22, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in bc16952 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
It was simply calling `SafePromiseAllSettled`, which itself calls `arrayToSafePromiseIterable` which wraps all promises into new `SafePromise` object and wraps it into a `SafeArrayIterator`. Since we don't care about the return value, we can take some shortcuts. PR-URL: #51243 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
It was simply calling `SafePromiseAllSettled`, which itself calls `arrayToSafePromiseIterable` which wraps all promises into new `SafePromise` object and wraps it into a `SafeArrayIterator`. Since we don't care about the return value, we can take some shortcuts. PR-URL: #51243 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was simply calling
SafePromiseAllSettled, which itself callsarrayToSafePromiseIterablewhich wraps all promises into newSafePromiseobject and wraps it into aSafeArrayIterator. Since we don't care about the return value, we can take some shortcuts.node/lib/internal/per_context/primordials.js
Lines 483 to 490 in fd21429