Skip to content

[v21.x backport] deps: update undici to 6.6.2 #51768

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v21.x backport] deps: update undici to 6.6.2 #51768

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Feb 15, 2024

This commit is the result of reverting the v5.28.3 security update
and then cleanly cherry-picking all 6.x updates from main until
6.6.2, which also includes the security fix.

Reverts: 9d2ac2b
Includes:

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. v21.x labels Feb 15, 2024
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57098/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57180/

@targos
Copy link
Member Author

targos commented Feb 19, 2024

I'll wait for #51792 to rebase.

@targos targos force-pushed the undici-backport-v21 branch from 376cc0e to c332fc0 Compare February 20, 2024 05:16
@targos
Copy link
Member Author

targos commented Feb 20, 2024

Rebased.

@targos targos force-pushed the undici-backport-v21 branch from c332fc0 to 57c0422 Compare February 20, 2024 05:18
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57189/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57195/

@targos targos mentioned this pull request Feb 20, 2024
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57237/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57265/

@marco-ippolito
Copy link
Member

@targos can you rebase, the CI should fine fine now

@targos
Copy link
Member Author

targos commented Feb 26, 2024

@marco-ippolito My branch is already up-to-date wrt. v21.x-staging

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57431/

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57457/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57459/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57464/

@jeremymeng @marco-ippolito
Revert "fs: remove workaround for esm package"
5aacd62 
This reverts commit 95b1989.

It appears that the workaround is still needed: issue nodejs#51081

Backport-PR-URL: nodejs#51390
PR-URL: nodejs#51390
Fixes: nodejs#51081
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57466/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57473/

@targos @marco-ippolito
deps: update undici to 6.6.2
d8a328f 
This commit is the result of reverting the v5.28.3 security update
and then cleanly cherry-picking all 6.x updates from `main` until
6.6.2, which also includes the security fix.
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57494/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57495/

marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
@targos @marco-ippolito
deps: update undici to 6.6.2
c6de7b1 
This commit is the result of reverting the v5.28.3 security update
and then cleanly cherry-picking all 6.x updates from `main` until
6.6.2, which also includes the security fix.

Backport-PR-URL: #51768
PR-URL: #51768
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
@targos @marco-ippolito
deps: update undici to 6.6.2
4ebb944 
This commit is the result of reverting the v5.28.3 security update
and then cleanly cherry-picking all 6.x updates from `main` until
6.6.2, which also includes the security fix.

Backport-PR-URL: #51768
PR-URL: #51667
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@marco-ippolito
Copy link
Member

Landed in 4ebb944

@targos targos deleted the undici-backport-v21 branch March 1, 2024 15:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @marco-ippolito @RafaelGSS @jeremymeng