Revert "build: only generate specified build type files" #53580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6cb940a.
nodejs-github-bot
added
build
targos
approved these changes
Jun 25, 2024
targos
added
the
dont-land-on-v22.x
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Jun 25, 2024
lpinca
approved these changes
Jun 25, 2024
legendecas
added
the
fast-track
|
Fast-track has been requested by @legendecas. Please 👍 to approve. |
|
Fast-tracking the revert to fix the ninja workflow composing with |
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ab5e58b |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6cb940a.
Refs: #53511 (comment)
I think an alternative should be making the generated
config.gypiworks in both Release mode and Debug mode.