Skip to content

src: remove redundant RsaPointer (use RSAPointer) #54003

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2024
Merged

src: remove redundant RsaPointer (use RSAPointer) #54003

merged 1 commit into from
Jul 25, 2024

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jul 23, 2024

No description provided.

@jasnell jasnell requested review from anonrig and tniessen July 23, 2024 12:15
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jul 23, 2024
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 24, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/60576/ 💛

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jul 24, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit a851d0c into nodejs:main Jul 25, 2024
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a851d0c

targos pushed a commit that referenced this pull request Jul 28, 2024
@jasnell @targos
src: remove redundant RsaPointer (use RSAPointer)
ea9b320 
PR-URL: #54003
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@jasnell @RafaelGSS
src: remove redundant RsaPointer (use RSAPointer)
ee82f22 
PR-URL: #54003
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @lpinca @anonrig @tniessen @targos