url: encode null character at the end of file path #54066
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #51167
Description
To maintain current performance while addressing the whitespace trimming issue, I opted to pre-encode the pathname. Modifying the URL parse function would require more extensive changes, so pre-encoding is a simpler solution.
Test
Previously, this would output
test-
, but now it correctly outputsfile:///[...]/test-%00
.Benchmark
The local benchmark doesn't show a statistically significant performance degradation