doc: reserve ABI 130 for Electron 33 #54383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Aug 14, 2024
anonrig
approved these changes
Aug 14, 2024
targos
approved these changes
Aug 15, 2024
lpinca
approved these changes
Aug 15, 2024
richardlau
added
author ready
MoLow
approved these changes
Aug 16, 2024
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54383 ✔ Done loading data for nodejs/node/pull/54383 ----------------------------------- PR info ------------------------------------ Title doc: reserve ABI 129 for Electron 33 (#54383) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch clavin:clavin/doc-electron-33-abi -> nodejs:main Labels doc, author ready Commits 1 - doc: reserve ABI 129 for Electron 33 Committers 1 - clavin <clavin@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/54383 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54383 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 14 Aug 2024 19:09:56 GMT ✔ Approvals: 5 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/54383#pullrequestreview-2239013261 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54383#pullrequestreview-2239341034 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/54383#pullrequestreview-2239663756 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54383#pullrequestreview-2239778310 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/54383#pullrequestreview-2241577490 ⚠ This PR has conflicts that must be resolved ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10425117279 |
|
129 now has been consumed in this commit |
clavin
force-pushed
the
clavin/doc-electron-33-abi
branch
from
90c2e9e to
d8bf700
Compare
clavin
changed the title
|
Rebased to use 130 instead. 😄 👍 |
jakecastelli
approved these changes
Aug 19, 2024
jakecastelli
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 80dac9e |
|
This didn't land cleanly on v22.x due to #54077. Can you create a manual backport? |
RafaelGSS
added
the
backport-requested-v22.x
|
👍 Created a manual backport to |
avivkeller
added
backport-open-v22.x
clavin
added a commit
to clavin/node
that referenced
this pull request
Aug 19, 2024
PR-URL: nodejs#54383 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
clavin
added a commit
to clavin/node
that referenced
this pull request
Aug 19, 2024
Backport-PR-URL: nodejs#54455 PR-URL: nodejs#54383 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
clavin
added a commit
to clavin/node
that referenced
this pull request
Aug 22, 2024
Backport-PR-URL: nodejs#54455 PR-URL: nodejs#54383 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
|
@RafaelGSS We don't need to backport these changes. It's easier to mark dont-land. |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 24, 2024
Backport-PR-URL: #54455 PR-URL: #54383 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
avivkeller
added
backported-to-v22.x
Merged
targos
added
the
dont-land-on-v20.x
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks! We're preparing for the Electron 32 release right now. As part of our regular process, I'm reserving a new ABI version for the next version of Electron. 😄