-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
meta: add more labels to dep-updaters #54454
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
marco-ippolito
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you check also v8 and openssl?
lpinca
approved these changes
Aug 20, 2024
Landed in 99f4a73 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 25, 2024
PR-URL: #54454 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54454 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the dependency updaters to have more labels:
When amaro is updated, it will also be labeled as strip-types
When brotli is updated, it will also be labeled as zlib
When c-ares is updated, it will also be labeled as cares
When gyp-next is updated, it will also be labeled as gyp
When icu is updated, it will also be labeled as icu
When sqlite is updated, it will also be labeled as sqlite
When zlib is updated, it will also be labeled as zlib
When openssl is updated, it will also be labeled as openssl
When v8 is updated, it will also be labeled as dependencies