Skip to content

doc: fix typo in CppgcMixin docs #54762

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2024
Merged

doc: fix typo in CppgcMixin docs #54762

merged 1 commit into from
Sep 5, 2024

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Sep 4, 2024 •
edited by aduh95
Loading

Refs: #52295

@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 4, 2024
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

@avivkeller avivkeller added lib / src Issues and PRs related to general changes in the lib or src directory. doc Issues and PRs related to the documentations. and removed needs-ci PRs that need a full CI run. labels Sep 4, 2024
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit 24302c9 into nodejs:main Sep 5, 2024
33 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 24302c9

@aduh95
Copy link
Contributor

aduh95 commented Sep 12, 2024

Marking as dont-land since #52295 is also marked as such

@aduh95 aduh95 added dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Sep 12, 2024
@aduh95 aduh95 mentioned this pull request Oct 14, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@joyeecheung @louwers
doc: fix typo in CppgcMixin docs
4db135b 
PR-URL: nodejs#54762
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@joyeecheung @tpoisseau
doc: fix typo in CppgcMixin docs
2d8d7ef 
PR-URL: nodejs#54762
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@daeyeon daeyeon daeyeon approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joyeecheung @nodejs-github-bot @aduh95 @lpinca @daeyeon @avivkeller