deps: patch V8 to 12.9.202.19 #55057
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dependencies
|
Review requested:
|
gengjiawen
approved these changes
Sep 22, 2024
richardlau
approved these changes
Sep 22, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
targos
approved these changes
Sep 22, 2024
targos
added
the
dont-land-on-v20.x
marco-ippolito
approved these changes
Sep 22, 2024
richardlau
added
dont-land-on-v18.x
commit-queue
RafaelGSS
approved these changes
Sep 22, 2024
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55057 ✔ Done loading data for nodejs/node/pull/55057 ----------------------------------- PR info ------------------------------------ Title deps: patch V8 to 12.9.202.19 (#55057) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/update-v8-patch -> nodejs:main Labels v8 engine, needs-ci, dependencies, dont-land-on-v18.x, dont-land-on-v20.x Commits 1 - deps: patch V8 to 12.9.202.19 Committers 1 - Node.js GitHub Bot <github-bot@iojs.org> PR-URL: https://github.com/nodejs/node/pull/55057 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55057 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 22 Sep 2024 00:35:00 GMT ✔ Approvals: 5 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/55057#pullrequestreview-2319954818 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/55057#pullrequestreview-2319955425 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/55057#pullrequestreview-2320080342 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/55057#pullrequestreview-2320652136 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/55057#pullrequestreview-2320832422 ✘ GitHub CI is still running ℹ Last Full PR CI on 2024-09-22T05:57:15Z: https://ci.nodejs.org/job/node-test-pull-request/62662/ - Querying data for job/node-test-pull-request/62662/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11004789220 |
|
The CQ failure would be solved by nodejs/node-core-utils#857. |
targos
added
the
dont-land-on-v22.x
targos
pushed a commit
that referenced
this pull request
Sep 25, 2024
Refs: v8/v8@12.9.202.18...12.9.202.19 PR-URL: #55057 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
|
Landed in 5ed3296 |
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Refs: v8/v8@12.9.202.18...12.9.202.19 PR-URL: nodejs#55057 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
Refs: v8/v8@12.9.202.18...12.9.202.19 PR-URL: nodejs#55057 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated patch update of V8 to 12.9.202.19.