Skip to content

[v20.x backport] buffer: fix out of range for toString #55213

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v20.x backport] buffer: fix out of range for toString #55213

wants to merge 1 commit into from

Conversation

jazelly
Copy link
Member

@jazelly jazelly commented Oct 1, 2024

Fixed the failing test by decreasing the buffer allocation size.

Refs: #54553
cc @targos

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Oct 1, 2024
@jazelly jazelly force-pushed the backport-54553 branch 2 times, most recently from 8eecdb8 to 0df499a Compare October 2, 2024 11:39
targos
targos approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jazelly @targos
buffer: fix out of range for toString
e53b79c 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#54553
Fixes: nodejs#52298
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@jazelly
Copy link
Member Author

jazelly commented Oct 3, 2024

The coverage report seems strange. I don't think this commit would drag down the coverage that much, nor did I see other merged commits with this coverage check.

@targos
Copy link
Member

targos commented Oct 3, 2024

We have this problem with all pull requests on v22.x and v20.x.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62909/

marco-ippolito pushed a commit that referenced this pull request Nov 16, 2024
@jazelly @targos @marco-ippolito
buffer: fix out of range for toString
6b3c24d 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #54553
Backport-PR-URL: #55213
Fixes: #52298
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Refs: #54553
@marco-ippolito
Copy link
Member

Landed in 6b3c24d

@jazelly jazelly deleted the backport-54553 branch November 25, 2024 22:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jazelly @targos @nodejs-github-bot @marco-ippolito