src: fix kill signal on Windows

[huseyinacacak-janea]

On Windows, where POSIX signals do not exist, the signal argument will be ignored, and the process will be killed forcefully and abruptly (similar to 'SIGKILL')

As stated in the documentation of Node.js, the signal parameter of child process kill function is ignored.

However, when we execute spawn(process.execPath, ['-v']).kill('SIGHUP');, it throws an exception with the code ENOSYS. This is not consistent with the documentation.

I've looked at the implementation in libuv and have seen that only four signal types are supported to kill a process on Windows.

This PR fixes this issue by changing the signal to SIGKILL if it differs from SIGQUIT, SIGTERM, SIGKILL, and SIGINT. In addition, there is a slight change in the documentation to clarify the signal parameter.

Fixes: #42923

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (eb63cd2) to head (fbbb15e).
Report is 190 commits behind head on main.

Files with missing lines	Patch %	Lines
src/process_wrap.cc	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55514      +/-   ##
==========================================
- Coverage   88.40%   88.40%   -0.01%     
==========================================
  Files         653      654       +1     
  Lines      187437   187747     +310     
  Branches    36073    36126      +53     
==========================================
+ Hits       165711   165978     +267     
- Misses      14956    15006      +50     
+ Partials     6770     6763       -7     

Files with missing lines	Coverage Δ
src/process_wrap.cc	84.32% <50.00%> (+0.90%)	⬆️

... and 85 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63348/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63357/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63428/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63429/

[jasnell]

Can this be simplified down to a for loop of test cases?

[huseyinacacak-janea]

Thank you for the review. Fixed it.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63488/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63526/

[huseyinacacak-janea]

Is there anything else I can do to help this PR move forward?

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/55514
✔  Done loading data for nodejs/node/pull/55514
----------------------------------- PR info ------------------------------------
Title      src: fix kill signal on Windows (#55514)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     huseyinacacak-janea:huseyin-10409-process-kill-signal -> nodejs:main
Labels     child_process, c++, needs-ci, commit-queue-squash
Commits    4
 - src: fix kill signal on Windows
 - Update doc/api/child_process.md
 - Update test/parallel/test-child-process-kill.js
 - fixup! src: fix kill signal on Windows
Committers 2
 - Hüseyin Açacak <huseyin@janeasystems.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/55514
Fixes: https://github.com/nodejs/node/issues/42923
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55514
Fixes: https://github.com/nodejs/node/issues/42923
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - Update doc/api/child_process.md
   ⚠  - Update test/parallel/test-child-process-kill.js
   ⚠  - fixup! src: fix kill signal on Windows
   ℹ  This PR was created on Thu, 24 Oct 2024 10:31:09 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55514#pullrequestreview-2393535306
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-11-12T10:37:04Z: https://ci.nodejs.org/job/node-test-pull-request/63526/
- Querying data for job/node-test-pull-request/63526/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11893278060