Skip to content

deps: update simdjson to 3.11.2 #56226

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of simdjson to 3.11.2.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Dec 11, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 11, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@anonrig
Copy link
Member

anonrig commented Dec 12, 2024

@lemire is this a bug with simdutf or due to extremely old macOS in node.js infra?

12:01:06 ../deps/simdjson/simdjson.cpp:2821:10: error: expected concept name with optional arguments
12:01:06     } -> std::convertible_to<typename std::remove_cvref_t<T>::value_type>;
12:01:06          ^
12:01:06 1 error generated.

@lemire
Copy link
Member

lemire commented Dec 12, 2024

It is likely that you are trying to compile C++20 code with a compiler system that is too old to support C++20 properly.

I will issue a patch release that checks for the LLVM version and does not rely on what the compiler claims.

@lemire
Copy link
Member

lemire commented Dec 12, 2024

@anonrig If I am reading this right, LLVM did something dirty where they claimed that they supported C++20 when they did not. But we can route around this by manually checking the LLVM version.

simdjson/simdjson#2313

@lpinca lpinca closed this Dec 13, 2024
@lpinca lpinca deleted the actions/tools-update-simdjson branch December 13, 2024 16:16
@lpinca
Copy link
Member

lpinca commented Dec 13, 2024

Closed in favor of #56250.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants