[20.x backport] src: add --env-file-if-exists flag
#56932
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
added
the
semver-minor
|
Review requested:
|
nodejs-github-bot
added
c++
|
Why are we backporting a semver minor to v20.x? |
I can't talk for anyone besides my own self, the reason I'm opening this backport PR is that I'd like to see it landed on 20.x. I believe there's a plan for an upcoming semver-minor 20.x release, so I'm hopeful this could be a part of it. |
Co-Authored-By: Cedric Staniewski <cedric@gmx.ca> PR-URL: nodejs#54237 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fixes: nodejs#50993 Refs: nodejs#51451 test: remove unnecessary comment src: conform to style guidelines src: change flag to `--env-file-optional` test: revert automatic linter changes doc: fix typos src: change flag to `--env-file-if-exists` src: refactor `env_file_data` and `GetEnvFileDataFromArgs` test: clean up tests src: print error when file not found test: remove unnecessary extras PR-URL: nodejs#53060 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
env-file-if-exists-20.x
branch
from
1d708fb to
c4e38c4
Compare
|
Maybe also this one? #56893 |
As `--env-file` is experimental, this must be marked as experimental as well. Refs: nodejs#56887 Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: nodejs#56893 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
marco-ippolito
approved these changes
Mar 6, 2025
marco-ippolito
pushed a commit
that referenced
this pull request
Mar 6, 2025
Fixes: #50993 Refs: #51451 test: remove unnecessary comment src: conform to style guidelines src: change flag to `--env-file-optional` test: revert automatic linter changes doc: fix typos src: change flag to `--env-file-if-exists` src: refactor `env_file_data` and `GetEnvFileDataFromArgs` test: clean up tests src: print error when file not found test: remove unnecessary extras PR-URL: #53060 Backport-PR-URL: #56932 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Mar 6, 2025
As `--env-file` is experimental, this must be marked as experimental as well. Refs: #56887 Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #56893 Backport-PR-URL: #56932 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
|
Landed in 73b5c16...9fda8e2 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of
--inDotenv::GetPathFromArgs#54237--env-file-if-existsflag #53060--env-file-if-existsflag as experimental #56893