-
Notifications
You must be signed in to change notification settings - Fork 31.3k
2025-02-13, Version 23.8.0 (Current) #57005
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #56328 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #56564 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #56599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #56739 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Distros may compile with a different openssl security level than the default. In addition there has been some discussion with respect to shipping with a different default security security level in different Node.js versions in order to main stabilty. Exposing the default openssl security level with let us have tests that work in these situations as well as allow applications to better cope with the avialable crypto algorithms. - add API to get openssl security level - modify one test to use security level instead of openssl version as an example Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #56601 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Add an option to suppress cases where warnings are on by default Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #56647 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #56779 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
`test-esm-loader-hooks-inspect-wait` is occasionally crashing on more platforms than Linux. Mark the test as flaky on those platforms as well. PR-URL: #56803 Refs: #54346 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #56783 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
The following tests - `test/parallel/test-https-client-renegotiation-limit.js` - `test/parallel/test-tls-alert-handling.js` - `test/parallel/test-tls-ocsp-callback.js` no longer use the OpenSSL CLI. Refs: #56714 (comment) PR-URL: #56784 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #56786 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
`StringUtil::CharacterCount` should return the length of underlying representation storage of a protocol string. `StringUtil::CharacterCount` is only used in DictionaryValue serialization. Only `Network.Headers` is an object type, represented with DictionaryValue. PR-URL: #56788 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Refs: #56751 Refs: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/32254/RUN_SUBSET=0,nodes=win2019-COMPILED_BY-vs2022/testReport/(root)/parallel/test_without_async_context_frame/ PR-URL: #56753 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Since the last security release, the resource check has been flaky on Windows. This commit temporarily disables those checks to unblock the next regular release. PR-URL: #56789 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #56675 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The cctest file `test_encoding_binding.cc` is never tested and it is not a valid test. Binding functions should never be tested with V8 API circumvented. A binding function should only be tested with JS calls. PR-URL: #56791 Refs: #55275 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
To prevent a new cctest missing from the `node.gyp`, search cctest files with tool `search_files.py` at configure time. PR-URL: #56791 Refs: #55275 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
`errorMessage` needs to be printed instead of `successMessage` in console.error(). ESM example is only fixed in previous PR. Refs: #56720 PR-URL: #56769 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #56798 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #56799 Refs: #56794 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #56807 Refs: nodejs/undici#4032 Refs: c1ccade Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: #56673 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Respectively to v0.9.1 and v0.0.7. PR-URL: #56815 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56250 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Yes, I'm pretty sure about that. The failure is not coming from |
I mean, Node.js core could have an unforeseen breaking change in the 115 commits of this PR. That's the whole point of running citgm. I never insinuated that there was a problem in |
I understand, that's the whole point of CITGM and |
@targos see https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3541/, same result for an older 23.x release. |
Considering the test is under parallel I think it could still be possible. In any case it seems the crash goes away after a rerun? |
Release build: https://ci-release.nodejs.org/job/iojs+release/10812/ |
Notable changes: crypto: * (SEMVER-MINOR) support --use-system-ca on Windows (Joyee Cheung) #56833 * (SEMVER-MINOR) added support for reading certificates from macOS system store (Tim Jacomb) #56599 deps: * update timezone to 2025a (Node.js GitHub Bot) #56876 sqlite: * (SEMVER-MINOR) allow returning `ArrayBufferView`s from user-defined functions (René) #56790 src: * set signal inspector io thread name (RafaelGSS) #56416 * set thread name for main thread and v8 worker (RafaelGSS) #56416 * set worker thread name using worker.name (RafaelGSS) #56416 * use a default thread name for inspector (RafaelGSS) #56416 url: * (SEMVER-MINOR) add URLPattern implementation (Yagiz Nizipli) #56452 zlib: * (SEMVER-MINOR) add zstd support (Jan Krems) #52100 PR-URL: #57005
@targos I was looking at the The following excerpt is from https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/nodes=ubuntu2204-64/3553/console
which comes from the last build step in https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/configure cc: @nodejs/build |
I think I finally found the reason why some Currently the listen paths are like the following on linux
and like the following on macOS
I think I really have to avoid using |
Oh, good catch! Maybe we should just use a shorter path in citgm. We don't need all the bits of a uuid. |
Please don't hardcode |
I'll also try shorten this https://github.com/websockets/ws/blob/976c53c4065c49ede73bfba824caf5a6e0f290cb/test/websocket.test.js#L1869. Four bytes should be sufficient. Anyway using |
Shorten the length of temporary file and UNIX domain socket paths. Refs: nodejs/node#57005 (comment)
Notable changes: crypto: * (SEMVER-MINOR) support --use-system-ca on Windows (Joyee Cheung) nodejs#56833 * (SEMVER-MINOR) added support for reading certificates from macOS system store (Tim Jacomb) nodejs#56599 deps: * update timezone to 2025a (Node.js GitHub Bot) nodejs#56876 sqlite: * (SEMVER-MINOR) allow returning `ArrayBufferView`s from user-defined functions (René) nodejs#56790 src: * set signal inspector io thread name (RafaelGSS) nodejs#56416 * set thread name for main thread and v8 worker (RafaelGSS) nodejs#56416 * set worker thread name using worker.name (RafaelGSS) nodejs#56416 * use a default thread name for inspector (RafaelGSS) nodejs#56416 url: * (SEMVER-MINOR) add URLPattern implementation (Yagiz Nizipli) nodejs#56452 zlib: * (SEMVER-MINOR) add zstd support (Jan Krems) nodejs#52100 PR-URL: nodejs#57005
2025-02-13, Version 23.8.0 (Current), @targos
Notable Changes
Support for using system CA certificates store on macOS and Windows
This version adds the
--use-system-ca
command-line flag, which instructs Node.jsto use the trusted CA certificates present in the system store along with
the
--use-bundled-ca
,--use-openssl-ca
options.This option is available on macOS and Windows for now.
Contributed by Tim Jacomb in #56599
and Joyee Cheung in #56833.
Introduction of the URL Pattern API
An implementation of the URL Pattern API
is now available.
The
URLPattern
constructor is exported from thenode:url
module and will beavailable as a global in Node.js 24.
Contributed by Yagiz Nizipli and Daniel Lemire in #56452.
Support for the zstd compression algorithm
Node.js now includes support for the Zstandard (zstd) compression algorithm.
Various APIs have been added to the
node:zlib
module for both compression and decompressionof zstd streams.
Contributed by Jan Krems in #52100.
Node.js thread names
Threads created by the Node.js process are now named to improve the debugging experience.
Worker threads will use the
name
option that can be passed to theWorker
constructor.Contributed by Rafael Gonzaga in #56416.
Timezone data has been updated to 2025a
Included changes:
Other Notable Changes
39997867cf
] - (SEMVER-MINOR) sqlite: allow returningArrayBufferView
s from user-defined functions (René) #56790Commits
0ee9c34d63
] - benchmark: add simple parse and test benchmarks for URLPattern (James M Snell) #56882b3f2045d14
] - build: gyp exclude libm linking on macOS (deepak1556) #56901e0dd9aefd6
] - build: remove explicit linker call to libm on macOS (deepak1556) #5690152399da780
] - build: link with Security.framework in GN build (Cheng) #56895582b9221c9
] - build: do not put commands in sources variables (Cheng) #56885ea61b956e9
] - build: add double quotes around <(python) (Luigi Pinca) #5682614236ef778
] - build: add build option suppress_all_error_on_warn (Michael Dawson) #56647dfd3f430f3
] - build,win: enable ccache (Stefan Stojanovic) #568473e207bd9ec
] - (SEMVER-MINOR) crypto: support --use-system-ca on Windows (Joyee Cheung) #56833fe2694a992
] - crypto: fix X509* leak in --use-system-ca (Joyee Cheung) #5683260039a2c36
] - crypto: add api to get openssl security level (Michael Dawson) #5660139a474f7c0
] - (SEMVER-MINOR) crypto: added support for reading certificates from macOS system store (Tim Jacomb) #56599144bee8067
] - deps: update zlib to 1.3.0.1-motley-788cb3c (Node.js GitHub Bot) #566557fd39e3a79
] - deps: update sqlite to 3.49.0 (Node.js GitHub Bot) #56654d698cb5434
] - deps: update amaro to 0.3.2 (marco-ippolito) #56916dbd09067c0
] - deps: V8: cherry-pick 9ab40592f697 (Levi Zim) #56781ee33ef3aa6
] - deps: update cjs-module-lexer to 2.0.0 (Michael Dawson) #56855c0542557d0
] - deps: update timezone to 2025a (Node.js GitHub Bot) #56876d67cb1f9bb
] - deps: update simdjson to 3.12.0 (Node.js GitHub Bot) #5687470b04b4314
] - deps: update googletest to e235eb3 (Node.js GitHub Bot) #56873e11cda003f
] - (SEMVER-MINOR) deps: update ada to v3.0.1 (Yagiz Nizipli) #564528743ef525d
] - deps: update simdjson to 3.11.6 (Node.js GitHub Bot) #562500f553e5575
] - deps: update amaro to 0.3.1 (Node.js GitHub Bot) #56785380a8d8d2f
] - (SEMVER-MINOR) deps,tools: add zstd 1.5.6 (Jan Krems) #5210066898a7c3b
] - doc: update history of stream.Readable.toWeb() (Jimmy Leung) #569289e29416e12
] - doc: make MDN links to global classes more consistent (Antoine du Hamel) #569246bc270728a
] - doc: make MDN links to global classes more consistent inassert.md
(Antoine du Hamel) #5692000da003171
] - doc: make MDN links to global classes more consistent (Antoine du Hamel) #56923d90198793a
] - doc: make MDN links to global classes more consistent inutil.md
(Antoine du Hamel) #569225f4377a759
] - doc: make MDN links to global classes more consistent inbuffer.md
(Antoine du Hamel) #569217353266b50
] - doc: improve type stripping documentation (Marco Ippolito) #56916888d2acc3a
] - doc: specificy support for erasable ts syntax (Marco Ippolito) #569163c082d43bc
] - doc: update post sec release process (Rafael Gonzaga) #56907f0bf35d3c5
] - doc: update websocket link to avoid linking to self (Chengzhong Wu) #56897373dbb0e6c
] - doc: mark--env-file-if-exists
flag as experimental (Juan José) #56893d436888cc8
] - doc: fix typo in cjs example ofutil.styleText
(Deokjin Kim) #5676991638eeb4a
] - doc: clarify sqlite user-defined function behaviour (René) #56786bab9c4d331
] - events: getMaxListeners detects 0 listeners (Matthew Aitken) #56807ccaf7fe737
] - fs: makeFileHandle.readableWebStream
always create byte streams (Ian Kerins) #55461974cec7a0a
] - http: be more generational GC friendly (ywave620) #56767be00058712
] - inspector: add Network.Initiator in inspector protocol (Chengzhong Wu) #5680531293a4b09
] - inspector: fix GN build (Cheng) #5679891a302356b
] - inspector: fix StringUtil::CharacterCount for unicodes (Chengzhong Wu) #567883b305f25f2
] - lib: filter node:quic from builtinModules when flag not used (James M Snell) #56870f06ee4c54a
] - meta: bumpactions/upload-artifact
from 4.4.3 to 4.6.0 (dependabot[bot]) #56861d230bc3b3c
] - meta: bumpactions/setup-node
from 4.1.0 to 4.2.0 (dependabot[bot]) #56868d4ecfa745e
] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #56889698c56bb94
] - meta: add @nodejs/url as codeowner (Chengzhong Wu) #56783a274b28857
] - module: fix require.resolve() crash on non-string paths (Aditi) #569424e3052aeee
] - quic: fixup errant LocalVector usage (James M Snell) #56564dfc61f7bb7
] - readline: fix unresolved promise on abortion (Daniel Venable) #540309e60501f5e
] - sqlite: fix coverity warnings related to backup() (Colin Ihrig) #569611913a4aabc
] - sqlite: restore changes from sqlite: cache column names in stmt.all() #55373 (Colin Ihrig) #569088410c955b7
] - sqlite: fix use-after-free in StatementSync due to premature GC (Divy Srivastava) #5684001d732d629
] - sqlite: handle conflicting SQLite and JS errors (Colin Ihrig) #5678739997867cf
] - (SEMVER-MINOR) sqlite: allow returningArrayBufferView
s from user-defined functions (René) #567908dc637681a
] - sqlite, test: expose sqlite online backup api (Edy Silva) #56253cfea53eccc
] - src: useargs.This()
in zlib (Michaël Zasso) #569886b398d6d0b
] - src: replaceSplitString
with built-in (Yagiz Nizipli) #54990fbb32e0a08
] - src: add nullptr handling forNativeKeyObject
(Burkov Egor) #5690083ff7be9fd
] - src: disallow copy/move fns/constructors (Yagiz Nizipli) #5681163611d0331
] - src: add a hard dependency v8_inspector_headers (Chengzhong Wu) #568053d957d135c
] - src: improve error handling in encoding_binding.cc (James M Snell) #569159e9ac3ccd8
] - src: avoid copy by using std::views::keys (Yagiz Nizipli) #56080086cdc297a
] - src: remove obsolete NoArrayBufferZeroFillScope (James M Snell) #56913915d7aeb37
] - src: set signal inspector io thread name (RafaelGSS) #56416f4b086d29d
] - src: set thread name for main thread and v8 worker (RafaelGSS) #564163579143630
] - src: set worker thread name using worker.name (RafaelGSS) #56416736ff5de6d
] - src: use a default thread name for inspector (RafaelGSS) #56416be8e2b4d8f
] - src: improve error handling in permission.cc (James M Snell) #56904d6cf0911ee
] - src: improve error handling in node_sqlite (James M Snell) #56891521fed1bac
] - src: improve error handling in node_os by removing ToLocalChecked (James M Snell) #56888c9a99df8e7
] - src: improve error handling in node_url (James M Snell) #568865c82ef3ace
] - src: add memory retainer traits for external types (Chengzhong Wu) #56881edb194b2d5
] - src: prevent URLPattern property accessors from crashing on invalid this (James M Snell) #568779624049414
] - src: pull in more electron boringssl adjustments (James M Snell) #56858f8910e384d
] - src: make multiple improvements to node_url_pattern (James M Snell) #5687194a0237b18
] - src: clean up some obsolete crypto methods (James M Snell) #56792b240ca67b9
] - src: add check for Bignum in GroupOrderSize (Burkov Egor) #5670245692e9c7c
] - src, deps: port electron's boringssl workarounds (James M Snell) #56812a9d80d43cb
] - (SEMVER-MINOR) src, quic: refine more of the quic implementation (James M Snell) #5632893d0beb6c8
] - src,test: expand test coverage for urlpattern and fix error (James M Snell) #568785a9732e1d0
] - test: improve timeout duration for debugger events (Yagiz Nizipli) #5697060c8fc07ff
] - test: remove unnecessary syscall to cpuinfo (Yagiz Nizipli) #5696840cdf756e6
] - test: update webstorage wpt (Yagiz Nizipli) #56963de77371a9e
] - test: execute shell directly for refresh() (Yagiz Nizipli) #55051f4254b8e70
] - test: automatically sync wpt urlpattern tests (Jonas) #56949a473d3f57a
] - test: update snapshots for amaro v0.3.2 (Marco Ippolito) #56916abca97f7e2
] - test: change jenkins reporter (Carlos Espa) #568087c9fa11127
] - test: fix race condition in test-child-process-bad-stdio (Colin Ihrig) #56845b8b6e68836
] - (SEMVER-MINOR) test: add WPT for URLPattern (Yagiz Nizipli) #56452b6d3d52e20
] - test: adjust check to use OpenSSL sec level (Michael Dawson) #568193beac87f92
] - test: test-crypto-scrypt.js doesn't need internals (Meghan Denny) #566733af23a10f3
] - test: settest-fs-cp
as flaky (Stefan Stojanovic) #567991146f48f67
] - test: search cctest files (Chengzhong Wu) #5679186c199b25a
] - test: convert test_encoding_binding.cc to a JS test (Chengzhong Wu) #56791bd5484717c
] - test: test-crypto-prime.js doesn't need internals (Meghan Denny) #56675f5f54414e4
] - test: temporary remove resource check from fs read-write (Rafael Gonzaga) #56789c8bd2ba0ad
] - test: mark test-without-async-context-frame flaky on windows (James M Snell) #567532c2e4a4ae0
] - test: remove unnecessary code (Luigi Pinca) #567844606a5f79b
] - test: marktest-esm-loader-hooks-inspect-wait
flaky (Richard Lau) #5680338c77e3462
] - test: update WPT for url to a23788b77a (Node.js GitHub Bot) #5677950ebd5fd31
] - test: remove duplicate error reporter from ci (Carlos Espa) #567390c3ae25aec
] - test_runner: print formatted errors on summary (Pietro Marchini) #56911b5a8a812fb
] - tools: bump eslint version (dependabot[bot]) #56869e1f86c1b9d
] - tools: remove test-asan/ubsan workflows (Michaël Zasso) #56823405a6678b7
] - tools: run macOS test workflow with Xcode 16.1 (Michaël Zasso) #5683116529c130f
] - tools: update sccache and sccache-action (Michaël Zasso) #56815fe004111ea
] - tools: fix license-builder for inspector_protocol (Michaël Zasso) #56814bc97a90176
] - (SEMVER-MINOR) url: add URLPattern implementation (Yagiz Nizipli) #5645277294d8918
] - util: enforce shouldColorize in styleText array arg (Marco Ippolito) #567228e6c191601
] - zlib: use modern class syntax for zstd classes (Yagiz Nizipli) #56965a3ca7f37a2
] - zlib: make all zstd functions experimental (Yagiz Nizipli) #569644cc7907738
] - (SEMVER-MINOR) zlib: add zstd support (Jan Krems) #52100