Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

src: fix node_config_file.h compilation error in GN build #57210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Feb 25, 2025

Fix the same compilation error of #57173, without breaking building after #57170.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 25, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (9fd90d9) to head (0268f3e).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57210      +/-   ##
==========================================
- Coverage   90.31%   90.27%   -0.04%     
==========================================
  Files         630      630              
  Lines      184513   184631     +118     
  Branches    36080    36114      +34     
==========================================
+ Hits       166643   166679      +36     
- Misses      10955    11007      +52     
- Partials     6915     6945      +30     

see 31 files with indirect coverage changes

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants