Skip to content

module: handle instantiated async module jobs in require(esm) #58067

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

module: handle instantiated async module jobs in require(esm) #58067

wants to merge 1 commit into from
+59 −11

Conversation

joyeecheung
Copy link
Member

When require(esm) encounters a cached module job that is instantiated but not yet evaluated, run the evaluation. This catches an edge case previously missed in #57187.

Fixes: #58061

@joyeecheung
module: handle instantiated async module jobs in require(esm)
da4207a 
When require(esm) encounters a cached module job that is instantiated
but not yet evaluated, run the evaluation. This catches an edge case
previously missed in nodejs#57187.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 29, 2025
@joyeecheung joyeecheung mentioned this pull request Apr 29, 2025
Open
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.21%. Comparing base (53abd1a) to head (da4207a).
Report is 79 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/modules/esm/module_job.js 79.41% 7 Missing ⚠️
src/module_wrap.cc 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58067   +/-   ##
=======================================
  Coverage   90.20%   90.21%           
=======================================
  Files         630      630           
  Lines      186391   186423   +32     
  Branches    36612    36615    +3     
=======================================
+ Hits       168134   168177   +43     
+ Misses      11068    11061    -7     
+ Partials     7189     7185    -4
Files with missing lines Coverage Δ
lib/internal/modules/esm/loader.js 96.07% <100.00%> (+1.02%) ⬆️
src/debug_utils.h 80.00% <ø> (ø)
src/module_wrap.h 0.00% <ø> (ø)
src/module_wrap.cc 72.38% <87.50%> (+0.02%) ⬆️
lib/internal/modules/esm/module_job.js 97.12% <79.41%> (-1.15%) ⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JakobJingleheimer
JakobJingleheimer approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66514/

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66586/

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
3 participants
@joyeecheung @nodejs-github-bot @JakobJingleheimer