test: fix failing test in test-tick-processor #5911

ghaiklor · 2016-03-26T08:00:26Z

Pull Request check-list

Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
this change (including linting)?
Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

test

Description of change

The problem in /RunInDebugContext/ regular expression. After investigating the isolate logs for this test-case, I've found nothing that satisfy this expression.

Possible solution can be flag i that fixes it.

Though, I think that it's just a typo in regular expression and there is should be lower-cased first letter.

The problem in /RunInDebugContext/ regular expression. After investigating the isolate logs for this test-case, I've found nothing that satisfy this expression. Possible solution can be flag i that fixes it.

ghaiklor · 2016-03-26T08:05:30Z

@matthewloring seems it was your change. Can you explain what exactly this regular expression checks in isolate logs?

matthewloring · 2016-03-26T15:46:16Z

The goal of this test is to check whether or not C++ functions are being symbolized correctly in tick processor output. The function vm.runInDebugContext invokes the C++ function RunInDebugContext which we check for using the regular expression. There are some operating systems that do not symbolize correctly but the test checks for them here. What operating system is this failing on for you?

ghaiklor · 2016-03-26T16:40:07Z

@matthewloring Mac OS X
There is a result of this test - #5903

matthewloring · 2016-03-26T17:11:46Z

I am not able to reproduce this locally with OS X 10.11.4. What is the output of nm <your_node_binary> | grep "RunInDebugContext"?

ghaiklor · 2016-03-26T17:36:15Z

@matthewloring

000000010074c362 T __ZN4node17ContextifyContext17RunInDebugContextERKN2v820FunctionCallbackInfoINS1_5ValueEEE

UPD: I've tried again right now on the master branch, still the same error.

ghaiklor · 2016-03-26T17:44:32Z

If it helps, here is my isolate log for this test-case - http://pastebin.com/zE9E96KF

balupton · 2016-03-27T06:47:53Z

I am not able to reproduce this locally with OS X 10.11.4. What is the output of nm <your_node_binary> | grep "RunInDebugContext"?

14:45:39:balupton@balmac.local:/Users/balupton/Projects/uni/node:(HEAD detached at v5.9.1)
$ nm ./node | grep "RunInDebugContext"
00000001006750fc T __ZN4node17ContextifyContext17RunInDebugContextERKN2v820FunctionCallbackInfoINS1_5ValueEEE

Running on OS X 10.11.4

balupton · 2016-03-27T06:49:04Z

Happy for someone to remote into my machine to debug - as it happens every time for for me.

balupton · 2016-03-27T07:14:25Z

Here is the output with a console.log(out):

diff --git a/test/parallel/test-tick-processor.js b/test/parallel/test-tick-processor.js
index b22e2ec..ba1f01a 100644
--- a/test/parallel/test-tick-processor.js
+++ b/test/parallel/test-tick-processor.js
@@ -55,6 +55,7 @@ function runTest(pattern, code) {
   var out = cp.execSync(process.execPath +
                         ' --prof-process --call-graph-size=10 ' + log,
                         {encoding: 'utf8'});
+  console.log(out);
   assert(pattern.test(out));
   fs.unlinkSync(log);
 }

15:02:50:balupton@balmac.local:/Users/balupton/Projects/uni/node:(HEAD detached at v5.9.1)
$ make test
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C out BUILDTYPE=Release V=1
make[1]: Nothing to be done for `all'.
ln -fs out/Release/node node
Running main() from gtest_main.cc
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from UtilTest
[ RUN      ] UtilTest.ListHead
[       OK ] UtilTest.ListHead (0 ms)
[----------] 1 test from UtilTest (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (0 ms total)
[  PASSED  ] 1 test.
/usr/local/opt/python/bin/python2.7 tools/test.py --mode=release message parallel sequential -J
=== release test-tick-processor ===                                            
Path: parallel/test-tick-processor
Statistical profiling result from isolate-0x102004000-v8.log, (1683 ticks, 3 unaccounted, 0 excluded).

 [Shared libraries]:
   ticks  total  nonlib   name
     65    3.9%          /Users/balupton/Projects/uni/node/out/Release/node
      6    0.4%          /usr/lib/system/libsystem_kernel.dylib
      4    0.2%          /usr/lib/system/libsystem_malloc.dylib
      2    0.1%          /usr/lib/system/libsystem_pthread.dylib
      2    0.1%          /usr/lib/system/libsystem_platform.dylib
      2    0.1%          /usr/lib/libstdc++.6.dylib
      1    0.1%          /usr/lib/system/libsystem_c.dylib

 [JavaScript]:
   ticks  total  nonlib   name
   1587   94.3%   99.1%  LazyCompile: *f [eval]:1:11
      2    0.1%    0.1%  Stub: JSEntryStub
      2    0.1%    0.1%  LazyCompile: *exports.setImmediate timers.js:557:32
      1    0.1%    0.1%  Stub: FastNewContextStub
      1    0.1%    0.1%  LazyCompile: ~processImmediate timers.js:500:26
      1    0.1%    0.1%  LazyCompile: ~normalize path.js:1218:32
      1    0.1%    0.1%  LazyCompile: ~<anonymous> [eval]:5:27
      1    0.1%    0.1%  LazyCompile: tryOnImmediate timers.js:531:24
      1    0.1%    0.1%  Handler: process
      1    0.1%    0.1%  Function: ~<anonymous> module.js:1:11

 [C++]:
   ticks  total  nonlib   name

 [Summary]:
   ticks  total  nonlib   name
   1598   94.9%   99.8%  JavaScript
      0    0.0%    0.0%  C++
      4    0.2%    0.2%  GC
     82    4.9%          Shared libraries
      3    0.2%          Unaccounted

 [C++ entry points]:
   ticks    cpp   total   name

 [Bottom up (heavy) profile]:
  Note: percentage shows a share of a particular caller in the total
  amount of its parent calls.
  Callers occupying less than 2.0% are not shown.

   ticks parent  name
   1587   94.3%  LazyCompile: *f [eval]:1:11
   1586   99.9%    LazyCompile: ~<anonymous> [eval]:5:27
   1586  100.0%      LazyCompile: tryOnImmediate timers.js:531:24
    817   51.5%        LazyCompile: *processImmediate timers.js:500:26
    769   48.5%        LazyCompile: ~processImmediate timers.js:500:26

     65    3.9%  /Users/balupton/Projects/uni/node/out/Release/node
     49   75.4%    /Users/balupton/Projects/uni/node/out/Release/node
     20   40.8%      LazyCompile: ~runInThisContext node.js:841:28
     20  100.0%        LazyCompile: ~NativeModule.compile node.js:922:44
     20  100.0%          LazyCompile: NativeModule.require node.js:856:34
      5   25.0%            Function: ~<anonymous> stream.js:1:11
      5  100.0%              LazyCompile: ~NativeModule.compile node.js:922:44
      5  100.0%                LazyCompile: NativeModule.require node.js:856:34
      5  100.0%                  Function: ~<anonymous> fs.js:1:11
      5  100.0%                    LazyCompile: ~NativeModule.compile node.js:922:44
      5  100.0%                      LazyCompile: NativeModule.require node.js:856:34
      3   15.0%            Function: ~<anonymous> module.js:1:11
      3  100.0%              LazyCompile: ~NativeModule.compile node.js:922:44
      3  100.0%                LazyCompile: NativeModule.require node.js:856:34
      3  100.0%                  LazyCompile: evalScript node.js:520:22
      3  100.0%                    LazyCompile: ~startup node.js:13:19
      3  100.0%                      Function: ~<anonymous> node.js:10:10
      2   10.0%            LazyCompile: ~startup.globalVariables node.js:219:37
      2  100.0%              LazyCompile: ~startup node.js:13:19
      2  100.0%                Function: ~<anonymous> node.js:10:10
      2   10.0%            LazyCompile: ~startup node.js:13:19
      2  100.0%              Function: ~<anonymous> node.js:10:10
      2   10.0%            LazyCompile: ~createWritableStdioStream node.js:555:37
      2  100.0%              LazyCompile: ~<anonymous> node.js:601:48
      2  100.0%                Function: ~<anonymous> console.js:1:11
      2  100.0%                  LazyCompile: ~NativeModule.compile node.js:922:44
      2  100.0%                    LazyCompile: NativeModule.require node.js:856:34
      2  100.0%                      LazyCompile: ~<anonymous> node.js:240:48
      2   10.0%            Function: ~<anonymous> fs.js:1:11
      2  100.0%              LazyCompile: ~NativeModule.compile node.js:922:44
      2  100.0%                LazyCompile: NativeModule.require node.js:856:34
      2  100.0%                  Function: ~<anonymous> module.js:1:11
      2  100.0%                    LazyCompile: ~NativeModule.compile node.js:922:44
      2  100.0%                      LazyCompile: NativeModule.require node.js:856:34
      2   10.0%            Function: ~<anonymous> assert.js:1:11
      2  100.0%              LazyCompile: ~NativeModule.compile node.js:922:44
      2  100.0%                LazyCompile: NativeModule.require node.js:856:34
      2  100.0%                  Function: ~<anonymous> timers.js:1:11
      2  100.0%                    LazyCompile: ~NativeModule.compile node.js:922:44
      2  100.0%                      LazyCompile: NativeModule.require node.js:856:34
      1    5.0%            LazyCompile: ~startup.globalTimeouts node.js:229:36
      1  100.0%              LazyCompile: ~startup node.js:13:19
      1  100.0%                Function: ~<anonymous> node.js:10:10
      1    5.0%            Function: ~<anonymous> timers.js:1:11
      1  100.0%              LazyCompile: ~NativeModule.compile node.js:922:44
      1  100.0%                LazyCompile: NativeModule.require node.js:856:34
      1  100.0%                  LazyCompile: ~startup.globalTimeouts node.js:229:36
      1  100.0%                    LazyCompile: ~startup node.js:13:19
      1  100.0%                      Function: ~<anonymous> node.js:10:10
      4    8.2%      LazyCompile: *f [eval]:1:11
      4  100.0%        LazyCompile: ~<anonymous> [eval]:5:27
      4  100.0%          LazyCompile: tryOnImmediate timers.js:531:24
      4  100.0%            LazyCompile: ~processImmediate timers.js:500:26
      2    4.1%      LazyCompile: ~exports.setImmediate timers.js:557:32
      2  100.0%        LazyCompile: *f [eval]:1:11
      2  100.0%          LazyCompile: ~<anonymous> [eval]:5:27
      2  100.0%            LazyCompile: tryOnImmediate timers.js:531:24
      2  100.0%              LazyCompile: ~processImmediate timers.js:500:26
      2    4.1%      Function: ~<anonymous> net.js:1:11
      2  100.0%        LazyCompile: ~NativeModule.compile node.js:922:44
      2  100.0%          LazyCompile: NativeModule.require node.js:856:34
      2  100.0%            LazyCompile: ~createWritableStdioStream node.js:555:37
      2  100.0%              LazyCompile: ~<anonymous> node.js:601:48
      2  100.0%                Function: ~<anonymous> console.js:1:11
      2  100.0%                  LazyCompile: ~NativeModule.compile node.js:922:44
      2  100.0%                    LazyCompile: NativeModule.require node.js:856:34
      2  100.0%                      LazyCompile: ~<anonymous> node.js:240:48
      1    2.0%      LazyCompile: ~startup.setupProcessObject node.js:188:40
      1  100.0%        LazyCompile: ~startup node.js:13:19
      1  100.0%          Function: ~<anonymous> node.js:10:10
      1    2.0%      LazyCompile: ~startup node.js:13:19
      1  100.0%        Function: ~<anonymous> node.js:10:10
      1    2.0%      LazyCompile: ~remove internal/linkedlist.js:28:16
      1  100.0%        LazyCompile: ~listOnTimeout timers.js:156:23
      1    2.0%      LazyCompile: ~processImmediate timers.js:500:26
      1    2.0%      LazyCompile: ~parse native json.js:43:19
      1  100.0%        LazyCompile: ~startup.processConfig node.js:294:35
      1  100.0%          LazyCompile: ~startup node.js:13:19
      1  100.0%            Function: ~<anonymous> node.js:10:10
      1    2.0%      LazyCompile: ~formatPrimitive util.js:452:25
      1  100.0%        LazyCompile: formatValue util.js:243:21
      1  100.0%          LazyCompile: ~inspect util.js:121:17
      1  100.0%            LazyCompile: ~exports.format util.js:20:26
      1  100.0%              LazyCompile: ~Console.log console.js:38:33
      1  100.0%                LazyCompile: ~<anonymous> native v8natives.js:1202:16
      1  100.0%                  LazyCompile: <anonymous> node.js:549:30
      1  100.0%                    LazyCompile: ~_combinedTickCallback node.js:374:35
      1  100.0%                      LazyCompile: ~_tickCallback node.js:396:27
      1    2.0%      LazyCompile: ~exports.setTimeout timers.js:311:30
      1  100.0%        Script: ~[eval]
      1  100.0%          /Users/balupton/Projects/uni/node/out/Release/node
      1  100.0%            LazyCompile: ~exports.runInThisContext vm.js:52:36
      1  100.0%              Function: ~<anonymous> [eval]-wrapper:1:11
      1  100.0%                LazyCompile: ~Module._compile module.js:380:37
      1  100.0%                  LazyCompile: <anonymous> node.js:549:30
      1  100.0%                    LazyCompile: ~_combinedTickCallback node.js:374:35
      1  100.0%                      LazyCompile: ~_tickCallback node.js:396:27
      1    2.0%      LazyCompile: ~defineProperties native v8natives.js:801:32
      1  100.0%        LazyCompile: ~create native v8natives.js:757:22
      1  100.0%          LazyCompile: ~startup node.js:13:19
      1  100.0%            Function: ~<anonymous> node.js:10:10
      1    2.0%      LazyCompile: ~createWriteReq net.js:703:24
      1  100.0%        LazyCompile: ~Socket._writeGeneric net.js:630:42
      1  100.0%          LazyCompile: ~Socket._write net.js:699:35
      1  100.0%            LazyCompile: ~doWrite _stream_writable.js:293:17
      1  100.0%              LazyCompile: ~writeOrBuffer _stream_writable.js:263:23
      1  100.0%                LazyCompile: ~Writable.write _stream_writable.js:194:36
      1  100.0%                  LazyCompile: ~Socket.write net.js:623:34
      1  100.0%                    LazyCompile: ~Console.log console.js:38:33
      1  100.0%                      LazyCompile: ~<anonymous> native v8natives.js:1202:16
      1    2.0%      LazyCompile: ~Socket net.js:115:16
      1  100.0%        LazyCompile: ~createWritableStdioStream node.js:555:37
      1  100.0%          LazyCompile: ~<anonymous> node.js:616:48
      1  100.0%            Function: ~<anonymous> console.js:1:11
      1  100.0%              LazyCompile: ~NativeModule.compile node.js:922:44
      1  100.0%                LazyCompile: NativeModule.require node.js:856:34
      1  100.0%                  LazyCompile: ~<anonymous> node.js:240:48
      1  100.0%                    LazyCompile: <anonymous> node.js:549:30
      1  100.0%                      LazyCompile: ~_combinedTickCallback node.js:374:35
      1    2.0%      LazyCompile: ~Revive native json.js:19:16
      1  100.0%        LazyCompile: ~Revive native json.js:19:16
      1  100.0%          LazyCompile: ~parse native json.js:43:19
      1  100.0%            LazyCompile: ~startup.processConfig node.js:294:35
      1  100.0%              LazyCompile: ~startup node.js:13:19
      1  100.0%                Function: ~<anonymous> node.js:10:10
      1    2.0%      LazyCompile: ~PropertyDescriptor native v8natives.js:284:28
      1  100.0%        LazyCompile: ~ToPropertyDescriptor native v8natives.js:237:30
      1  100.0%          LazyCompile: ~defineProperty native v8natives.js:766:30
      1  100.0%            LazyCompile: ~<anonymous> fs.js:176:50
      1  100.0%              LazyCompile: ~InnerArrayForEach native array.js:942:27
      1  100.0%                LazyCompile: ~forEach native array.js:961:22
      1  100.0%                  Function: ~<anonymous> fs.js:1:11
      1  100.0%                    LazyCompile: ~NativeModule.compile node.js:922:44
      1  100.0%                      LazyCompile: NativeModule.require node.js:856:34
      1    2.0%      LazyCompile: ~NativeModule.cache node.js:935:42
      1  100.0%        LazyCompile: NativeModule.require node.js:856:34
      1  100.0%          Function: ~<anonymous> module.js:1:11
      1  100.0%            LazyCompile: ~NativeModule.compile node.js:922:44
      1  100.0%              LazyCompile: NativeModule.require node.js:856:34
      1  100.0%                LazyCompile: evalScript node.js:520:22
      1  100.0%                  LazyCompile: ~startup node.js:13:19
      1  100.0%                    Function: ~<anonymous> node.js:10:10
      1    2.0%      LazyCompile: ~EventEmitter.init events.js:36:29
      1  100.0%        LazyCompile: ~EventEmitter events.js:5:22
      1  100.0%          LazyCompile: ~Stream stream.js:22:16
      1  100.0%            LazyCompile: ~Writable _stream_writable.js:138:18
      1  100.0%              LazyCompile: ~Duplex _stream_duplex.js:23:16
      1  100.0%                LazyCompile: ~Socket net.js:115:16
      1  100.0%                  LazyCompile: ~createWritableStdioStream node.js:555:37
      1  100.0%                    LazyCompile: ~<anonymous> node.js:601:48
      1  100.0%                      Function: ~<anonymous> console.js:1:11
      1    2.0%      LazyCompile: ~DefineOwnProperty native v8natives.js:633:27
      1  100.0%        LazyCompile: ~defineProperty native v8natives.js:766:30
      1  100.0%          Function: ~<anonymous> events.js:1:11
      1  100.0%            LazyCompile: ~NativeModule.compile node.js:922:44
      1  100.0%              LazyCompile: NativeModule.require node.js:856:34
      1  100.0%                LazyCompile: ~startup node.js:13:19
      1  100.0%                  Function: ~<anonymous> node.js:10:10
      1    2.0%      LazyCompile: NativeModule.require node.js:856:34
      1  100.0%        LazyCompile: ~startup node.js:13:19
      1  100.0%          Function: ~<anonymous> node.js:10:10
      1    2.0%      LazyCompile: NativeModule node.js:846:24
      1  100.0%        LazyCompile: NativeModule.require node.js:856:34
      1  100.0%          LazyCompile: ~startup.globalVariables node.js:219:37
      1  100.0%            LazyCompile: ~startup node.js:13:19
      1  100.0%              Function: ~<anonymous> node.js:10:10
      1    2.0%      LazyCompile: *exports.setImmediate timers.js:557:32
      1  100.0%        LazyCompile: *f [eval]:1:11
      1  100.0%          LazyCompile: ~<anonymous> [eval]:5:27
      1  100.0%            LazyCompile: tryOnImmediate timers.js:531:24
      1  100.0%              LazyCompile: *processImmediate timers.js:500:26
      1    2.0%      Function: ~<anonymous> node.js:10:10
      1    2.0%      Function: ~<anonymous> native harmony-object.js:2:10
      1    2.0%      Function: ~<anonymous> constants.js:1:11
      1  100.0%        LazyCompile: ~NativeModule.compile node.js:922:44
      1  100.0%          LazyCompile: NativeModule.require node.js:856:34
      1  100.0%            Function: ~<anonymous> fs.js:1:11
      1  100.0%              LazyCompile: ~NativeModule.compile node.js:922:44
      1  100.0%                LazyCompile: NativeModule.require node.js:856:34
      1  100.0%                  Function: ~<anonymous> module.js:1:11
      1  100.0%                    LazyCompile: ~NativeModule.compile node.js:922:44
      1  100.0%                      LazyCompile: NativeModule.require node.js:856:34


Statistical profiling result from isolate-0x101804a00-v8.log, (1689 ticks, 6 unaccounted, 0 excluded).

 [Shared libraries]:
   ticks  total  nonlib   name
   1580   93.5%          /Users/balupton/Projects/uni/node/out/Release/node
     28    1.7%          /usr/lib/system/libsystem_malloc.dylib
     21    1.2%          /usr/lib/system/libsystem_kernel.dylib
     17    1.0%          /usr/lib/system/libsystem_platform.dylib
     14    0.8%          /usr/lib/system/libsystem_c.dylib
      2    0.1%          /usr/lib/system/libsystem_pthread.dylib
      1    0.1%          /usr/lib/libstdc++.6.dylib

 [JavaScript]:
   ticks  total  nonlib   name
      6    0.4%   23.1%  Function: ~<anonymous> native mirrors.js:2:10
      2    0.1%    7.7%  Stub: CEntryStub
      2    0.1%    7.7%  LazyCompile: ~MakeMirror native mirrors.js:62:20
      2    0.1%    7.7%  Function: ~<anonymous> native debug.js:2:10
      1    0.1%    3.8%  Stub: JSEntryStub
      1    0.1%    3.8%  Stub: CreateWeakCellStub
      1    0.1%    3.8%  Stub: CEntryStub {1}
      1    0.1%    3.8%  LazyCompile: ~processImmediate timers.js:500:26
      1    0.1%    3.8%  LazyCompile: ~DoConstructRegExp native regexp.js:20:27
      1    0.1%    3.8%  Handler: An IC handler from the snapshot
      1    0.1%    3.8%  Builtin: JSEntryTrampoline
      1    0.1%    3.8%  Builtin: CompileLazy

 [C++]:
   ticks  total  nonlib   name

 [Summary]:
   ticks  total  nonlib   name
     20    1.2%   76.9%  JavaScript
      0    0.0%    0.0%  C++
     40    2.4%  153.8%  GC
   1663   98.5%          Shared libraries
      6    0.4%          Unaccounted

 [C++ entry points]:
   ticks    cpp   total   name

 [Bottom up (heavy) profile]:
  Note: percentage shows a share of a particular caller in the total
  amount of its parent calls.
  Callers occupying less than 2.0% are not shown.

   ticks parent  name
   1580   93.5%  /Users/balupton/Projects/uni/node/out/Release/node
   1512   95.7%    /Users/balupton/Projects/uni/node/out/Release/node
   1154   76.3%      LazyCompile: ~exports.runInDebugContext vm.js:38:37
   1154  100.0%        LazyCompile: ~f [eval]:1:11
   1146   99.3%          LazyCompile: ~<anonymous> [eval]:3:27
   1146  100.0%            LazyCompile: tryOnImmediate timers.js:531:24
   1146  100.0%              LazyCompile: ~processImmediate timers.js:500:26
     71    4.7%      Function: ~<anonymous> native mirrors.js:2:10
     66   93.0%        /Users/balupton/Projects/uni/node/out/Release/node
     66  100.0%          LazyCompile: ~exports.runInDebugContext vm.js:38:37
     66  100.0%            LazyCompile: ~f [eval]:1:11
     66  100.0%              LazyCompile: ~<anonymous> [eval]:3:27
     66  100.0%                LazyCompile: tryOnImmediate timers.js:531:24
     66  100.0%                  LazyCompile: ~processImmediate timers.js:500:26
      5    7.0%        LazyCompile: *f [eval]:1:11
      5  100.0%          LazyCompile: ~<anonymous> [eval]:3:27
      5  100.0%            LazyCompile: tryOnImmediate timers.js:531:24
      5  100.0%              LazyCompile: ~processImmediate timers.js:500:26
     53    3.5%      Function: ~<anonymous> native debug.js:2:10
     49   92.5%        /Users/balupton/Projects/uni/node/out/Release/node
     49  100.0%          LazyCompile: ~exports.runInDebugContext vm.js:38:37
     49  100.0%            LazyCompile: ~f [eval]:1:11
     49  100.0%              LazyCompile: ~<anonymous> [eval]:3:27
     49  100.0%                LazyCompile: tryOnImmediate timers.js:531:24
     49  100.0%                  LazyCompile: ~processImmediate timers.js:500:26
      4    7.5%        LazyCompile: *f [eval]:1:11
      4  100.0%          LazyCompile: ~<anonymous> [eval]:3:27
      4  100.0%            LazyCompile: tryOnImmediate timers.js:531:24
      4  100.0%              LazyCompile: ~processImmediate timers.js:500:26
     41    2.7%      LazyCompile: *f [eval]:1:11
     41  100.0%        LazyCompile: ~<anonymous> [eval]:3:27
     41  100.0%          LazyCompile: tryOnImmediate timers.js:531:24
     41  100.0%            LazyCompile: ~processImmediate timers.js:500:26
     39    2.6%      /Users/balupton/Projects/uni/node/out/Release/node
     39  100.0%        LazyCompile: ~exports.runInDebugContext vm.js:38:37
     39  100.0%          LazyCompile: ~f [eval]:1:11
     38   97.4%            LazyCompile: ~<anonymous> [eval]:3:27
     38  100.0%              LazyCompile: tryOnImmediate timers.js:531:24
     38  100.0%                LazyCompile: ~processImmediate timers.js:500:26
      1    2.6%            Script: ~[eval]
      1  100.0%              /Users/balupton/Projects/uni/node/out/Release/node
      1  100.0%                LazyCompile: ~exports.runInThisContext vm.js:52:36
      1  100.0%                  Function: ~<anonymous> [eval]-wrapper:1:11
      1  100.0%                    LazyCompile: ~Module._compile module.js:380:37
      1  100.0%                      LazyCompile: <anonymous> node.js:549:30
assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: false == true
    at runTest (/Users/balupton/Projects/uni/node/test/parallel/test-tick-processor.js:59:3)
    at Object.<anonymous> (/Users/balupton/Projects/uni/node/test/parallel/test-tick-processor.js:38:1)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:142:18)
    at node.js:939:3
Command: out/Release/node /Users/balupton/Projects/uni/node/test/parallel/test-tick-processor.js
[00:55|% 100|+ 1046|-   1]: Done                                               
make: *** [test] Error 1

ghaiklor · 2016-03-27T08:06:07Z

@balupton better to paste it on pastebin, thanks. Your message is too long.

ghaiklor · 2016-03-27T08:08:52Z

@matthewloring I see now, what regular expression checks. Just dive in a little bit in C++ code. In that case, problem here that we don't have any C++ call from that function. Isolate log says here 0% of C++ code at all. Any suggestions, how can I fix this?

matthewloring · 2016-03-27T19:39:39Z

@ghaiklor It means that V8 is unable to resolve the C++ symbol that corresponds to the RunInDebugContext function call. I don't know off the top of my head what could cause that issue but I can look into it some more.

matthewloring · 2016-03-27T19:41:49Z

Actually, looks like @indutny found the culprit here: #5903 (comment). I am running OS X 10.11.4 though so I'm not sure why the problem isn't reproducing for me.

indutny · 2016-03-27T19:47:14Z

@matthewloring that's strange... may I ask you to give a try to that patch that I posted there? Does it still work after applying it?

indutny · 2016-03-27T19:47:40Z

I'm sorry, but this PR is not a fix for the problem, as it matches JS symbol instead of a C++ one. Closing!

ghaiklor · 2016-03-27T19:53:25Z

@indutny thanks for fix, I can delete branch now.

Just checked your patch locally, works like a charm.

test: fix failing test in test-tick-processor

c3bb8ec

The problem in /RunInDebugContext/ regular expression. After investigating the isolate logs for this test-case, I've found nothing that satisfy this expression. Possible solution can be flag i that fixes it.

thefourtheye added the test Issues and PRs related to the tests. label Mar 26, 2016

indutny closed this Mar 27, 2016

ghaiklor deleted the fix/5903 branch March 27, 2016 19:53

matthewloring mentioned this pull request Apr 7, 2016

test: test-tick-processor was failing on mac osx. #6091

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix failing test in test-tick-processor #5911

test: fix failing test in test-tick-processor #5911

ghaiklor commented Mar 26, 2016

ghaiklor commented Mar 26, 2016

matthewloring commented Mar 26, 2016

ghaiklor commented Mar 26, 2016

matthewloring commented Mar 26, 2016

ghaiklor commented Mar 26, 2016

ghaiklor commented Mar 26, 2016

balupton commented Mar 27, 2016

balupton commented Mar 27, 2016

balupton commented Mar 27, 2016

ghaiklor commented Mar 27, 2016

ghaiklor commented Mar 27, 2016

matthewloring commented Mar 27, 2016

matthewloring commented Mar 27, 2016

indutny commented Mar 27, 2016

indutny commented Mar 27, 2016

ghaiklor commented Mar 27, 2016

test: fix failing test in test-tick-processor #5911

test: fix failing test in test-tick-processor #5911

Conversation

ghaiklor commented Mar 26, 2016

Pull Request check-list

Affected core subsystem(s)

Description of change

ghaiklor commented Mar 26, 2016

matthewloring commented Mar 26, 2016

ghaiklor commented Mar 26, 2016

matthewloring commented Mar 26, 2016

ghaiklor commented Mar 26, 2016

ghaiklor commented Mar 26, 2016

balupton commented Mar 27, 2016

balupton commented Mar 27, 2016

balupton commented Mar 27, 2016

ghaiklor commented Mar 27, 2016

ghaiklor commented Mar 27, 2016

matthewloring commented Mar 27, 2016

matthewloring commented Mar 27, 2016

indutny commented Mar 27, 2016

indutny commented Mar 27, 2016

ghaiklor commented Mar 27, 2016