Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

doc: remove all scrollbar styling #6479

Closed

Conversation

claudiorodriguez
Copy link
Contributor

Checklist
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Returns the scrollbar to native style.
Alternative to #6474 and #6445

Fixes: #6443

Returns the scrollbar to native style.

Fixes: nodejs#6443
@claudiorodriguez claudiorodriguez added the doc Issues and PRs related to the documentations. label Apr 29, 2016
@jasnell
Copy link
Member

jasnell commented Apr 29, 2016

@nodejs/documentation @nodejs/website

@ChALkeR
Copy link
Member

ChALkeR commented Apr 29, 2016

Actually, that would be a perfect solution.

@eljefedelrodeodeljefe
Copy link
Contributor

Let's do it. LGTM

@ghost
Copy link

ghost commented Apr 29, 2016

LGTM!

@silverwind
Copy link
Contributor

Eh, I think we've bikeshedded this to death, so LGTM. Bit of a shame that this won't emulate OS X scrollbars on Windows anymore, but I guess we let Browsers solve that "issue".

@eljefedelrodeodeljefe
Copy link
Contributor

Bikesheds are built on weekends :)

@jasnell
Copy link
Member

jasnell commented Apr 29, 2016

I'm gonna create a bikeshed-this label so people know where the really good bikeshed conversations are happening. Good idea or no? ;-)

@ghost
Copy link

ghost commented Apr 29, 2016

@jasnell 👍 hell yeah

@eljefedelrodeodeljefe
Copy link
Contributor

+1 -1 +1 -1 +1 -1 +1 -1 +1 -1 +1 -1

@ChALkeR
Copy link
Member

ChALkeR commented Apr 29, 2016

LGTM.

@claudiorodriguez
Copy link
Contributor Author

Merging this tomorrow if there's no objections

@claudiorodriguez
Copy link
Contributor Author

Landed in 7fdffb6

claudiorodriguez added a commit that referenced this pull request May 1, 2016
Returns the doc custom scrollbar to native style.

Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
Returns the doc custom scrollbar to native style.

Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
Returns the doc custom scrollbar to native style.

Fixes: nodejs#6443
PR-URL: nodejs#6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@zertosh
Copy link
Contributor

zertosh commented May 8, 2016

Chrome (at least on a Mac) will give you indicators on the scrollbar of where cmd+f results are. Using custom styles on the scrollbar breaks this – so I'm glad to see it works again in the narrow view. However, in the wide view, since the content area's scrollbars are not on the body, they still don't work there:

scrollbars-find

@ChALkeR
Copy link
Member

ChALkeR commented May 8, 2016

@zertosh I suggest filing a separate issue for this, if there isn't one already.

@eljefedelrodeodeljefe
Copy link
Contributor

Did one for you. Couldn't find any... #6637 Thanks for reporting, this bugged me for a while too.

MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
Returns the doc custom scrollbar to native style.

Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Returns the doc custom scrollbar to native style.

Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Returns the doc custom scrollbar to native style.

Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Scrollbar width
7 participants