-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
doc: remove all scrollbar styling #6479
doc: remove all scrollbar styling #6479
Conversation
Returns the scrollbar to native style. Fixes: nodejs#6443
@nodejs/documentation @nodejs/website |
Actually, that would be a perfect solution. |
Let's do it. LGTM |
LGTM! |
Eh, I think we've bikeshedded this to death, so LGTM. Bit of a shame that this won't emulate OS X scrollbars on Windows anymore, but I guess we let Browsers solve that "issue". |
Bikesheds are built on weekends :) |
I'm gonna create a |
@jasnell 👍 hell yeah |
+1 -1 +1 -1 +1 -1 +1 -1 +1 -1 +1 -1 |
LGTM. |
Merging this tomorrow if there's no objections |
Landed in 7fdffb6 |
Returns the doc custom scrollbar to native style. Fixes: nodejs#6443 PR-URL: nodejs#6479 Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Chrome (at least on a Mac) will give you indicators on the scrollbar of where |
@zertosh I suggest filing a separate issue for this, if there isn't one already. |
Did one for you. Couldn't find any... #6637 Thanks for reporting, this bugged me for a while too. |
Checklist
Affected core subsystem(s)
doc
Description of change
Returns the scrollbar to native style.
Alternative to #6474 and #6445
Fixes: #6443