-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Document http "aborted" events #7270
Conversation
I think you can squash the commits together and add an This looks good to me, but my knowledge of the HTTP implementation in core is not too extensive, so /cc @nodejs/http |
LGTM, the commits can definitely be squashed but that can be done by whomever lands. |
Separate PR for a test checking |
Landed in 86fdbe0 Many thanks, and I think it’s safe to say that a separate PR for testing this event on client responses would be appreciated! :) |
Checklist
(This PR just adds doc)make -j4 test
(UNIX) orvcbuild test nosign
(Windows) passesa test and/or benchmark is included(This PR just adds doc)Affected core subsystem(s)
doc (for HTTP)
Description of change
This pull request follows on #6925 (in which @Fishrock123 and @dougwilson made key appearances) to document the
"aborted"
(as opposed to"abort"
) events emitted on HTTP requests and responses on socket closure by the remote system.A few links from the issue that seem most relevant:
'aborted'
from the corresponding response (req.res
).'aborted'
from requests.'aborted'
The last tests the event on
req
from the server point of view. I actually don't see a test checking the event from the client API. This test sets a handler on ares
from anhttp.get
call, but as far as I can tell there's no test verifying its functionality. I can try and cook one up if needed._Be Warned! This is my first PR to Node.js. I reread CONTRIBUTING, but probably screwed something up anyway. Many thanks to team for patience and understanding!_
This PR coming to you live from doc sprint at NodeConf Adventure.