Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

inspector: print warning when used #7383

Merged
merged 1 commit into from
Jun 28, 2016
Merged

inspector: print warning when used #7383

merged 1 commit into from
Jun 28, 2016

Conversation

evanlucas
Copy link
Contributor

@evanlucas evanlucas commented Jun 23, 2016 •
edited
Loading

Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

inspector

Description of change

This is done to note that this is an experimental feature.

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 23, 2016
@evanlucas
Copy link
Contributor Author

/cc @ofrobots

@MylesBorins
Copy link
Contributor

LGTM

@ofrobots
Copy link
Contributor

LGTM!

@mscdex mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Jun 23, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jun 23, 2016

I'd say "experimental feature", but other than that, LGTM.

@evanlucas
Copy link
Contributor Author

@cjihrig yea, good call.

@Fishrock123
Copy link
Contributor

Maybe surround it with *? lgtm

@evanlucas
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/3088/

@jasnell
Copy link
Member

jasnell commented Jun 27, 2016

LGTM

@evanlucas
inspector: print warning when used
a77f6eb 
This is done to note that this is an experimental feature.

PR-URL: nodejs#7383
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas closed this Jun 28, 2016
@evanlucas evanlucas deleted the inspectorwarn branch June 28, 2016 14:07
@evanlucas
Copy link
Contributor Author

Landed in a77f6eb. Thanks!

@evanlucas evanlucas merged commit a77f6eb into nodejs:master Jun 28, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
@evanlucas @Fishrock123
inspector: print warning when used
fe580eb 
This is done to note that this is an experimental feature.

PR-URL: #7383
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@evanlucas @MylesBorins @ofrobots @cjihrig @Fishrock123 @jasnell @mscdex @nodejs-github-bot