Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

doc: fix typo in email address in README #8941

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 5, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

@JacksonTian please review. Thanks!

@Trott Trott added the doc Issues and PRs related to the documentations. label Oct 5, 2016
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 5, 2016
@jasnell
Copy link
Member

jasnell commented Oct 6, 2016

LGTM. I'd say this is trivial enough not to wait the full 48 hours.

@gibfahn
Copy link
Member

gibfahn commented Oct 7, 2016

LGTM if @JacksonTian agrees, I feel we should probably have his sign-off too right?

@ChALkeR
Copy link
Member

ChALkeR commented Oct 7, 2016

Introduced in #6388.

@Trott
Copy link
Member Author

Trott commented Oct 11, 2016

@JacksonTian Can you take a quick look at this change?

@JacksonTian
Copy link
Contributor

LGTM

@JacksonTian
Copy link
Contributor

landed in 6de9d13

thanks @Trott .

JacksonTian pushed a commit that referenced this pull request Oct 11, 2016
PR-URL: #8941
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
PR-URL: #8941
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 12, 2016
PR-URL: #8941
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
PR-URL: #8941
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
@Trott Trott deleted the jacksontianemail branch January 13, 2022 22:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants