Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: remove out-of-date TODO comment #9000

Closed
wants to merge 1 commit into from
Closed

src: remove out-of-date TODO comment #9000

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Oct 10, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

This commit attempts to fix one of the items in
#4641, which was to remove a
TODO the UDPWrap::OnSend function and share the code in that method with
StreamWrap::AfterWrite.

While looking into this addaleax pointed out that the implementations
for these two functions have diverged since the original comment
was added:

$ git log --pretty=short -u -L 357,357:src/udp_wrap.cc

$ git show cbd4033:src/udp_wrap.cc |
grep -1 -A26 'UDPWrap::OnSend'

git show cbd4033:src/stream_wrap.cc |
grep -A27 'void StreamWrap::AfterWrite'

Removing the TODO comment seems appropriate in this case.

@danbev
src: remove out-of-date TODO comment
3d77a37 
This commit attempts to fix one of the items in
nodejs#4641, which was to remove a
TODO the UDPWrap::OnSend function and share the code in that method with
StreamWrap::AfterWrite.

While looking into this addaleax pointed out that the implementations
for these two functions have diverged since the original comment
was added:

$ git log --pretty=short -u -L 357,357:src/udp_wrap.cc

$ git show cbd4033:src/udp_wrap.cc |
grep -1 -A26 'UDPWrap::OnSend'

git show cbd4033:src/stream_wrap.cc |
grep -A27 'void StreamWrap::AfterWrite'

Removing the TODO comment seems appropriate in this case.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 10, 2016
@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Oct 10, 2016
@mscdex
Copy link
Contributor

mscdex commented Oct 10, 2016

/cc @bnoordhuis ?

jasnell
jasnell approved these changes Oct 10, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Oct 10, 2016

Trivial enough not to have to wait the full 48 hours. Will get this landed.

@jasnell jasnell self-assigned this Oct 10, 2016
jasnell pushed a commit that referenced this pull request Oct 10, 2016
@danbev @jasnell
src: remove out-of-date TODO comment
1bfa026 
This commit attempts to fix one of the items in
#4641, which was to remove a
TODO the UDPWrap::OnSend function and share the code in that method with
StreamWrap::AfterWrite.

While looking into this addaleax pointed out that the implementations
for these two functions have diverged since the original comment
was added:

$ git log --pretty=short -u -L 357,357:src/udp_wrap.cc

$ git show cbd4033:src/udp_wrap.cc |
grep -1 -A26 'UDPWrap::OnSend'

git show cbd4033:src/stream_wrap.cc |
grep -A27 'void StreamWrap::AfterWrite'

Removing the TODO comment seems appropriate in this case.

PR-URL: #9000
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jasnell
Copy link
Member

jasnell commented Oct 10, 2016

Landed in 1bfa026

@jasnell jasnell closed this Oct 10, 2016
jasnell pushed a commit that referenced this pull request Oct 10, 2016
@danbev @jasnell
src: remove out-of-date TODO comment
556e4c1 
This commit attempts to fix one of the items in
#4641, which was to remove a
TODO the UDPWrap::OnSend function and share the code in that method with
StreamWrap::AfterWrite.

While looking into this addaleax pointed out that the implementations
for these two functions have diverged since the original comment
was added:

$ git log --pretty=short -u -L 357,357:src/udp_wrap.cc

$ git show cbd4033:src/udp_wrap.cc |
grep -1 -A26 'UDPWrap::OnSend'

git show cbd4033:src/stream_wrap.cc |
grep -A27 'void StreamWrap::AfterWrite'

Removing the TODO comment seems appropriate in this case.

PR-URL: #9000
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@danbev danbev deleted the remove-OnSend-comment branch October 11, 2016 08:35
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@danbev @Fishrock123
src: remove out-of-date TODO comment
443bede 
This commit attempts to fix one of the items in
#4641, which was to remove a
TODO the UDPWrap::OnSend function and share the code in that method with
StreamWrap::AfterWrite.

While looking into this addaleax pointed out that the implementations
for these two functions have diverged since the original comment
was added:

$ git log --pretty=short -u -L 357,357:src/udp_wrap.cc

$ git show cbd4033:src/udp_wrap.cc |
grep -1 -A26 'UDPWrap::OnSend'

git show cbd4033:src/stream_wrap.cc |
grep -A27 'void StreamWrap::AfterWrite'

Removing the TODO comment seems appropriate in this case.

PR-URL: #9000
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@danbev
src: remove out-of-date TODO comment
e5d2a95 
This commit attempts to fix one of the items in
#4641, which was to remove a
TODO the UDPWrap::OnSend function and share the code in that method with
StreamWrap::AfterWrite.

While looking into this addaleax pointed out that the implementations
for these two functions have diverged since the original comment
was added:

$ git log --pretty=short -u -L 357,357:src/udp_wrap.cc

$ git show cbd4033:src/udp_wrap.cc |
grep -1 -A26 'UDPWrap::OnSend'

git show cbd4033:src/stream_wrap.cc |
grep -A27 'void StreamWrap::AfterWrite'

Removing the TODO comment seems appropriate in this case.

PR-URL: #9000
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
Merged
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

@jasnell jasnell

Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @mscdex @jasnell @bnoordhuis @cjihrig @MylesBorins @nodejs-github-bot