Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

http: name anonymous functions in _http_server #9060

Closed
wants to merge 1 commit into from

Conversation

maasencioh
Copy link
Contributor

Checklist
  • commit message follows commit guidelines
Description of change

Ref: #8913

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Oct 12, 2016
@MylesBorins
Copy link
Contributor

@maasencioh if you are going to be submitting a large number of these changes it might make sense to group them, even if they are still separate commits. I would say likely a single PR per subsystem would make sense.

I think we may have originally suggested only submitting a single file so that we could get on the same page about what these changes should be

@maasencioh
Copy link
Contributor Author

@thealphanerd I thought that you need different PR per file too, but if you agree then I could make a single PR with http files then

@maasencioh
Copy link
Contributor Author

@thealphanerd I move them to #9055, thanks for the advise

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants