Skip to content

doc: clarify slashes-appending in url module #9731

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

doc: clarify slashes-appending in url module #9731

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 22, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc url

Description of change

Refs: #9521

@Trott Trott added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Nov 22, 2016
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Nov 22, 2016
lpinca
lpinca reviewed Nov 22, 2016
View reviewed changes
doc/api/url.md
* `urlObject.slashes` property is true;
* `urlObject.protocol` begins with `http`, `https`, `ftp`, `gopher`, or
`file`;
* `urlObject.protocol` is `undefined`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?

> url.format({ hostname: 'example.com' })
'example.com'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears not. I'll update it.

Trott added a commit to Trott/io.js that referenced this pull request Nov 24, 2016
@Trott
doc: clarify slashes-appending in url module
c1133f4 
PR-URL: nodejs#9731
Ref: nodejs#9521
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Nov 24, 2016 •
edited
Loading

Landed in c1133f4

@Trott Trott closed this Nov 24, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@Trott @addaleax
doc: clarify slashes-appending in url module
77e145a 
PR-URL: #9731
Ref: #9521
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@Trott @MylesBorins
doc: clarify slashes-appending in url module
4b7200e 
PR-URL: #9731
Ref: #9521
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@Trott @MylesBorins
doc: clarify slashes-appending in url module
ab4a98e 
PR-URL: #9731
Ref: #9521
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
@avgaltsev avgaltsev mentioned this pull request Mar 21, 2017
Closed
@Trott Trott deleted the relative-file branch January 13, 2022 22:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @lpinca @MylesBorins @nodejs-github-bot