Skip to content

Extendable ca certs v6 #9770

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Extendable ca certs v6 #9770

wants to merge 2 commits into from

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Nov 23, 2016 •
edited
Loading

Backport of #9139 to v6 to resolve conflicts.

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

tls,https

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v6.x labels Nov 23, 2016
@MylesBorins MylesBorins added lts-agenda semver-minor PRs that contain new features and should be released in the next minor version. labels Nov 28, 2016
mhdawson
mhdawson approved these changes Dec 6, 2016
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github
Copy link
Contributor Author

Thanks for the reviews.

For the info of any watchers - we are waiting on LTS agenda before this can be landed. If it impacts you with v4 or v6, comment on #9139 .

@MylesBorins
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/5514/

@sam-github sam-github force-pushed the extendable-ca-certs-v6 branch from 9ba05a3 to de42b88 Compare January 3, 2017 21:44
@jasnell
Copy link
Member

jasnell commented Jan 6, 2017

@nodejs/lts ... any objections to getting this landed in v6.x-staging?

@mhdawson
Copy link
Member

+1 from me and I think it was agreed in the latest LTS meeting that it will go out in the next semver minor release.

@mhdawson
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5782/

@sam-github
src: add wrapper for process.emitWarning()
1122d01 
PR-URL: nodejs#9139
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@sam-github
crypto: allow adding extra certs to well-known CAs
dc1bb52 
In closed environments, self-signed or privately signed certificates are
commonly used, and rejected by Node.js since their root CAs are not
well-known. Allow extending the set of well-known compiled-in CAs via
environment, so they can be set as a matter of policy.

PR-URL: nodejs#9139
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@sam-github sam-github force-pushed the extendable-ca-certs-v6 branch from de42b88 to dc1bb52 Compare January 10, 2017 18:50
@sam-github
Copy link
Contributor Author

@nodejs/build Any idea why tes/arm shows up as failed in CI above, but not in jenkins, https://ci.nodejs.org/job/node-test-commit-arm/7007/?

I rebased onto v6.x-staging, anything ele I need to do here?

@gibfahn
Copy link
Member

gibfahn commented Jan 11, 2017

@sam-github not an issue: nodejs/build#572

@italoacasas
Copy link
Contributor

ping @sam-github

@sam-github
Copy link
Contributor Author

pong @italoacasas

@sam-github
Copy link
Contributor Author

@MylesBorins do I push this onto v6.x-staging, or does the 6.x maintainer pull it on?

@MylesBorins
Copy link
Contributor

After the last round of audits on v6.x the original PR can now be cherry-picked onto the v6.x-staging branch with the test suite passing!

closing

@sam-github sam-github deleted the extendable-ca-certs-v6 branch January 24, 2017 19:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sam-github @MylesBorins @jasnell @mhdawson @gibfahn @italoacasas @nodejs-github-bot