http: remove stale timeout listeners

[evantorrie]

Checklist

• make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

http

Description of change

Fix memory leak #9268 introduced by ee7af01

Unifies handling of timeout set via http#request (i.e. prior to socket connect) with explicit ClientRequest.prototype.setTimeout. Previously, setTimeout would only apply if socket was writeable. Now, the timeout is applied regardless of whether socket is writeable, i.e. it applies to connect + write + read response combined.

Alternative solution to #9440

[Fishrock123]

@cjihrig @jasnell @evanlucas @bnoordhuis you all LGTM'd the alternative PR, is this one less favorable?

[bnoordhuis]

I wasn't aware this PR existed. :-) It has the benefit of creating fewer closures. That's never a bad thing.

[evanlucas]

@evantorrie can you rebase this off of current master? Thanks!

[jasnell]

#9440 landed. Closing this without landing