-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[tests]Changed var -> const, assert.equal -> assert.strictEqual #9884
Conversation
@troy0820 please change the commit msg as |
Changed commit message @princejwesley 💥 👍 |
48528b5
to
081cdc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for participating in Code and Learn! Welcome to Node.js!
@troy0820 I'm really sorry about this but it looks like I messed up and gave a small number of people duplicate tasks at the Code & Learn. Unfortunately, this was one of them. Would it be OK with you if we closed this one and I privately sent you another similar task? This is totally my fault and I apologize. |
@Trott That's perfectly alright. Whatever you need me to do just send my way and I'll do that. 👍🏽 |
Closing. Sorry about the confusion. |
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
Tests
Description of change
var
toconst
assert.equal
toassert.strictEqual