Skip to content

test: changed assert.Equal to asset.strictEqual #9973

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: changed assert.Equal to asset.strictEqual #9973

wants to merge 1 commit into from

Conversation

pchinjr
Copy link
Contributor

@pchinjr pchinjr commented Dec 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

40:3 changed assert.Equal() to assert.strictEqual()

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 6, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5240/

Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
@pchinjr @Fishrock123
test: changed assert.Equal to asset.strictEqual
df65999 
test-dgram-send-callback-recursive.js

PR-URL: #9973
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Thanks for your contribution! Landed in df65999 :D

@Fishrock123 Fishrock123 closed this Dec 6, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
@pchinjr @Fishrock123
test: changed assert.Equal to asset.strictEqual
f531c96 
test-dgram-send-callback-recursive.js

PR-URL: #9973
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@pchinjr @addaleax
test: changed assert.Equal to asset.strictEqual
223ec17 
test-dgram-send-callback-recursive.js

PR-URL: nodejs#9973
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@pchinjr
test: changed assert.Equal to asset.strictEqual
e4f94a7 
test-dgram-send-callback-recursive.js

PR-URL: nodejs#9973
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@pchinjr @MylesBorins
test: changed assert.Equal to asset.strictEqual
63f571e 
test-dgram-send-callback-recursive.js

PR-URL: #9973
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@pchinjr @MylesBorins
test: changed assert.Equal to asset.strictEqual
97bb0c1 
test-dgram-send-callback-recursive.js

PR-URL: #9973
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@pchinjr @MylesBorins
test: changed assert.Equal to asset.strictEqual
a958aa7 
test-dgram-send-callback-recursive.js

PR-URL: #9973
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced Dec 21, 2016
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@pchinjr @Trott @Fishrock123 @jasnell @cjihrig @mscdex @MylesBorins @addaleax @imyller @nodejs-github-bot