Skip to content

test: updating test file to use strictEqual #9985

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

test: updating test file to use strictEqual #9985

wants to merge 1 commit into from

Conversation

ashtonian
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

updating test file to use assert.strictEqual() instead of
assert.equal()

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 1, 2016

nit: there is a typo in the commit message

@ashtonian ashtonian changed the title test: updatig test file to use strictEqual test: updating test file to use strictEqual Dec 1, 2016
updating test file to use assert.strictEqual() instead of
assert.equal()
@ashtonian
Copy link
Contributor Author

Fixed.

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM.

@Trott
Copy link
Member

Trott commented Dec 8, 2016

@Trott
Copy link
Member

Trott commented Dec 8, 2016

These changes have already landed via another pull request. Looks like I might have given this task out twice. Sorry for my error! Glad to see your other pull request (#10080) landed! I'm going to close this one. Again, sorry about my mistake!

@Trott Trott closed this Dec 8, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants