Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Possible line spacing issue in nightly docs #1399

Closed
vsemozhetbyt opened this issue Oct 14, 2017 · 2 comments
Closed

Possible line spacing issue in nightly docs #1399

vsemozhetbyt opened this issue Oct 14, 2017 · 2 comments

Comments

@vsemozhetbyt
Copy link
Contributor

It seems nightly docs have unequal line spacing in lines with and without code fragments, Compare:

https://nodejs.org/api/tty.html

0

https://nodejs.org/download/nightly/v9.0.0-nightly20171013981595c316/docs/api/tty.html

1
@fhemberger
Copy link
Contributor

line-height is missing in the nightly docs. Maybe changes made in nodejs/node#15660 are not deployed there?

/cc @silverwind @lpinca

@silverwind
Copy link
Contributor

silverwind commented Oct 14, 2017 •
edited
Loading

I removed p {line-height: 1.5} because it seemed superflous. The case here is that <code> sets it to 1.5, but <p> defaults to 1.2. Restoring that rule fixes it. I'll send a PR.

silverwind added a commit to silverwind/node that referenced this issue Oct 14, 2017
@silverwind
doc: fix paragraph line-height issue
3ad3f8a 
Fix a line-height issue introduced in nodejs#15660 where paragraphs
containing <code> blocks would have unequal line heights.

Fixes: nodejs/nodejs.org#1399
@silverwind silverwind mentioned this issue Oct 14, 2017
Closed
2 tasks
silverwind added a commit to nodejs/node that referenced this issue Oct 15, 2017
@silverwind
doc: fix paragraph line-height issue
4247913 
Fix a line-height issue introduced in #15660 where paragraphs
containing <code> blocks would have unequal line heights.

Fixes: nodejs/nodejs.org#1399
PR-URL: #16200
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit to ayojs/ayo that referenced this issue Oct 15, 2017
@silverwind @addaleax
doc: fix paragraph line-height issue
4bcff09 
Fix a line-height issue introduced in #15660 where paragraphs
containing <code> blocks would have unequal line heights.

Fixes: nodejs/nodejs.org#1399
PR-URL: nodejs/node#16200
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit to nodejs/node that referenced this issue Oct 18, 2017
@silverwind @targos
doc: fix paragraph line-height issue
c23bf96 
Fix a line-height issue introduced in #15660 where paragraphs
containing <code> blocks would have unequal line heights.

Fixes: nodejs/nodejs.org#1399
PR-URL: #16200
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@silverwind @fhemberger @vsemozhetbyt