Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make position of "Edit on GitHub" link consistent #445

Merged
merged 2 commits into from
Jan 9, 2016

Conversation

strawbrary
Copy link
Contributor

Currently if the headline is long, it will push the "Edit on GitHub" link down as can be seen on the "Get Involved" page:
screen shot 2016-01-04 at 20 02 49

This commit moves the link before the headline so that it is always in the top right:
screen shot 2016-01-04 at 20 03 33

Moved the link before the headline so that it is always in the top right
@fhemberger
Copy link
Contributor

Good catch, but we should try to move the edit link out of the <h1> completely for search engine indexing/a11y reasons.

@strawbrary
Copy link
Contributor Author

@fhemberger Thanks, I hadn't considered that. Probably would have been bad to have all the search engine results start with "Edit on GitHub" heh. Moved it outside and increased the font-size for .edit-link since it doesn't inherit the h1 font-size anymore.

fhemberger added a commit that referenced this pull request Jan 9, 2016
Make position of "Edit on GitHub" link consistent
@fhemberger fhemberger merged commit 1618ebd into nodejs:master Jan 9, 2016
@fhemberger
Copy link
Contributor

Great, thank you! Merged.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants