Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

comment gitignore and add commonly ignored stuff #538

Merged
merged 1 commit into from
Feb 25, 2016

Conversation

ghost
Copy link

@ghost ghost commented Feb 25, 2016

was missing the infamous .DS_Store. also, are there any windows/linux files to be commonly ignored? i'm running OSX, so i don't really know.

@phillipj
Copy link
Member

Travis build passed 👍

@phillipj
Copy link
Member

😎

phillipj added a commit that referenced this pull request Feb 25, 2016
comment gitignore and add commonly ignored stuff
@phillipj phillipj merged commit e965a90 into master Feb 25, 2016
@phillipj phillipj deleted the add-stuff-to-gitignore branch February 25, 2016 21:38
node_modules/
npm-debug.log
.npm/

# OSX system files, the bane of our existence
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be in your global I think.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i always put them in there for safety :S

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also used to including these in every project. I never remember to add these globally, so I like to not "require" others to do it either.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants