Skip to content

Blog: v22.4.0 release post #6888

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2024
Merged

Blog: v22.4.0 release post #6888

merged 1 commit into from
Jul 2, 2024

Conversation

targos
Copy link
Member

@targos targos commented Jul 2, 2024

@targos targos requested a review from a team as a code owner July 2, 2024 09:08
@vercel Vercel
Copy link

vercel bot commented Jul 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ❌ Failed (Inspect) Jul 2, 2024 9:08am

@targos targos added the github_actions:pull-request Trigger Pull Request Checks label Jul 2, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Running Lighthouse audit...

@targos targos enabled auto-merge July 2, 2024 09:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.411s ⏱️

@targos
Copy link
Member Author

targos commented Jul 2, 2024

Vercel error:

Running "[[ "$VERCEL_GIT_COMMIT_REF" =~ dependabot* || "$VERCEL_GIT_COMMIT_REF" =~ gh-readonly* ]]"
Error: The specified Root Directory "apps/site" does not exist. Please update your Project Settings. Learn More: https://vercel.com/docs/build-step#root-directory
The specified Root Directory "apps/site" does not exist. Please update your Project Settings.

I have no idea what to do here.

@AugustinMauroy
Copy link
Member

@ovflowd I thinks you change something on Vercel config to allow monorepo ?

mikeesto
mikeesto approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. With the push to a monorepo CI isn't aligned correctly right now, this should still be fine to merge as we have done for other recent blog posts.

@targos
Copy link
Member Author

targos commented Jul 2, 2024

I don't know how to go forward with the two failed checks

@ovflowd ovflowd merged commit c19f996 into nodejs:main Jul 2, 2024
13 of 15 checks passed
@targos targos deleted the v22.4.0 branch July 3, 2024 06:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mikeesto mikeesto mikeesto approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @AugustinMauroy @mikeesto @RafaelGSS @ovflowd