-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgrade airtap and use GitHub Actions #443
Conversation
This comment has been minimized.
This comment has been minimized.
Because playwright has an install step that fails on node < 10. Ref nodejs/readable-stream#443
78fed0c
to
405790c
Compare
They keys are set up |
- Upgrade airtap to v4 - Move Sauce Labs tests from Travis to GitHub Actions - Use playwright for headless local testing
405790c
to
ce87b75
Compare
Build failed:
Will see if I can replicate that on another repo that has an almost identical setup, and no sauce connect problems. |
With debug output enabled, the problem seems to be the credentials:
@mcollina Could you please double-check the credentials? You can also try it locally: SAUCE_USERNAME=xx SAUCE_ACCESS_KEY=xx DEBUG=airtap* npm run test-browsers
# Run a diagnostic test
SAUCE_USERNAME=xx SAUCE_ACCESS_KEY=xx ./node_modules/sauce-connect-launcher/sc/sc-4.6.2-linux/bin/sc --doctor |
Thanks! Fixed and now the tests are passing! |
Running
|
@mcollina That hostname error is expected. Some browsers don't route localhost traffic through the Sauce Connect tunnel. To work around that, airtap uses a custom hostname that defaults to The debug steps I added in the last commit should be removed, especially |
oh gosh... can you send a fresh PR? |
Remove debug steps from sauce workflow (#443), remove travis, and replace badges in readme.
Remove debug steps from sauce workflow (#443), remove travis, and replace badges in readme.
Complements #418.