fix: method is not required for request api (#1175)

nodejs · Feb 3, 2022 · 1204ed1 · 1204ed1
1 parent eff93fb
commit 1204ed1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/test/types/api.test-d.ts b/test/types/api.test-d.ts
@@ -4,6 +4,7 @@ import { Dispatcher, request, stream, pipeline, connect, upgrade } from '../..'
 
 // request
 expectAssignable<Promise<Dispatcher.ResponseData>>(request(''))
+expectAssignable<Promise<Dispatcher.ResponseData>>(request('', { }))
 expectAssignable<Promise<Dispatcher.ResponseData>>(request('', { method: 'GET' }))
 
 // stream

diff --git a/types/api.d.ts b/types/api.d.ts
@@ -13,7 +13,7 @@ export {
 /** Performs an HTTP request. */
 declare function request(
   url: string | URL | UrlObject,
-  options?: { dispatcher?: Dispatcher } & Omit<Dispatcher.RequestOptions, 'origin' | 'path'>,
+  options?: { dispatcher?: Dispatcher } & Omit<Dispatcher.RequestOptions, 'origin' | 'path' | 'method'> & Partial<Pick<Dispatcher.RequestOptions, 'method'>>,
 ): Promise<Dispatcher.ResponseData>;
 
 /** A faster version of `request`. */