h2: do not emit data after goaway (#3811)

Signed-off-by: Matteo Collina <hello@matteocollina.com>
nodejs · Nov 8, 2024 · a2f63e7 · a2f63e7
1 parent 928bd10
commit a2f63e7
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/dispatcher/client-h2.js b/lib/dispatcher/client-h2.js
@@ -510,16 +510,18 @@ function writeH2 (client, request) {
   })
 
   stream.once('error', function (err) {
+    stream.removeAllListeners('data')
     abort(err)
   })
 
   stream.once('frameError', (type, code) => {
+    stream.removeAllListeners('data')
     abort(new InformationalError(`HTTP/2: "frameError" received - type ${type}, code ${code}`))
   })
 
-  // stream.on('aborted', () => {
-  //   // TODO(HTTP/2): Support aborted
-  // })
+  stream.on('aborted', () => {
+    stream.removeAllListeners('data')
+  })
 
   // stream.on('timeout', () => {
   //   // TODO(HTTP/2): Support timeout