-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: upgrade llhttp to 9.2.0 #2705
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2705 +/- ##
==========================================
- Coverage 85.54% 85.28% -0.27%
==========================================
Files 76 84 +8
Lines 6858 7592 +734
==========================================
+ Hits 5867 6475 +608
- Misses 991 1117 +126 ☔ View full report in Codecov by Sentry. |
81dedda
to
dc1dac3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
fixed the tests imho ready for merge. |
Maybe we should first release a undici 6.6.2 before we merge this? |
I'm still not sure about the right semver change but yes, let's merge this first. |
I took the version from HEAD of the default branch of llhttp. Can you make a release of llhttp? THan we just fix the version in this PR. |
Sure, I'll release llhttp after lunch. |
@Uzlopak llhttp 9.2.0. has just been released. You can quickly rework this PR and then we're ready to go. |
Thanks. I just patched the version in the header file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I think we should add support/expose the leniency flags, and potentially read those values from node.js core itself. That can be done in a follow-up PR.
@mcollina Target changed to next branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* upgrade llhttp * fix tests * set version of llhttp 9.2.0
* upgrade llhttp * fix tests * set version of llhttp 9.2.0
* upgrade llhttp * fix tests * set version of llhttp 9.2.0
* upgrade llhttp * fix tests * set version of llhttp 9.2.0
* upgrade llhttp * fix tests * set version of llhttp 9.2.0
* upgrade llhttp * fix tests * set version of llhttp 9.2.0
* upgrade llhttp * fix tests * set version of llhttp 9.2.0
To check if this closes #2678 you can runCan your run some benchmarks on this please?
@ShogunPanda