fix: ensure onConnect is always called

lib/api/api-pipeline.js

@@ -145,15 +145,14 @@ class PipelineHandler extends AsyncResource {
   }
 
   onConnect (abort, context) {
-    const { ret, res } = this
+    const { res } = this
 
     if (this.reason) {
       abort(this.reason)
       return
     }
 
     assert(!res, 'pipeline cannot be retried')
-    assert(!ret.destroyed)
 
     this.abort = abort
     this.context = context

lib/core/request.js

@@ -26,6 +26,7 @@ const { headerNameLowerCasedRecord } = require('./constants')
 const invalidPathRegex = /[^\u0021-\u00ff]/
 
 const kHandler = Symbol('handler')
+const noop = () => {}
 
 class Request {
   constructor (origin, {
@@ -296,6 +297,13 @@ class Request {
     }
     this.aborted = true
 
+    if (!this.abort) {
+      // Make sure to always call onConnect even on errors to avoid
+      // a common user mistake of assuming that onConnect is always
+      // called before any other hook.
+      this[kHandler].onConnect(noop)
+    }
+
     return this[kHandler].onError(error)
   }
 

lib/handler/decorator-handler.js

@@ -1,7 +1,13 @@
 'use strict'
 
+const assert = require('node:assert')
+const noop = () => {}
+
 module.exports = class DecoratorHandler {
   #handler
+  #onConnectCalled = false
+  #onCompleteCalled = false
+  #onErrorCalled = false
 
   constructor (handler) {
     if (typeof handler !== 'object' || handler === null) {
@@ -11,34 +17,60 @@ module.exports = class DecoratorHandler {
   }
 
   onConnect (...args) {
+    this.#onConnectCalled = true
     return this.#handler.onConnect?.(...args)
   }
 
   onError (...args) {
+    if (!this.#onConnectCalled) {
+      this.#onConnectCalled = true
+      this.#handler.onConnect?.(noop)
+    }
+
+    this.#onErrorCalled = true
     return this.#handler.onError?.(...args)
   }
 
   onUpgrade (...args) {
+    assert(!this.#onCompleteCalled)
+    assert(!this.#onErrorCalled)
+
     return this.#handler.onUpgrade?.(...args)
   }
 
   onResponseStarted (...args) {
+    assert(!this.#onCompleteCalled)
+    assert(!this.#onErrorCalled)
+
     return this.#handler.onResponseStarted?.(...args)
   }
 
   onHeaders (...args) {
+    assert(!this.#onCompleteCalled)
+    assert(!this.#onErrorCalled)
+
     return this.#handler.onHeaders?.(...args)
   }
 
   onData (...args) {
+    assert(!this.#onCompleteCalled)
+    assert(!this.#onErrorCalled)
+
     return this.#handler.onData?.(...args)
   }
 
   onComplete (...args) {
+    assert(!this.#onCompleteCalled)
+    assert(!this.#onErrorCalled)
+
+    this.#onCompleteCalled = true
     return this.#handler.onComplete?.(...args)
   }
 
   onBodySent (...args) {
+    assert(!this.#onCompleteCalled)
+    assert(!this.#onErrorCalled)
+
     return this.#handler.onBodySent?.(...args)
   }
 }