Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: don't override user defined MaxListeners #3372

Merged
merged 10 commits into from
Jun 26, 2024
Merged

Conversation

fawazahmed0
Copy link
Contributor

@fawazahmed0 fawazahmed0 commented Jun 25, 2024

Fixes nodejs/node#47449

Please note, I haven't tested this PR.

Status

@metcoder95 metcoder95 requested a review from KhafraDev June 25, 2024 18:17
@KhafraDev
Copy link
Member

Please add a test

@fawazahmed0
Copy link
Contributor Author

@KhafraDev

test/fetch/max-listeners.js Outdated Show resolved Hide resolved
test/fetch/max-listeners.js Outdated Show resolved Hide resolved
test/fetch/max-listeners.js Outdated Show resolved Hide resolved
fawazahmed0 and others added 4 commits June 26, 2024 04:43
Co-authored-by: tsctx <91457664+tsctx@users.noreply.github.com>
Co-authored-by: tsctx <91457664+tsctx@users.noreply.github.com>
@fawazahmed0 fawazahmed0 requested a review from tsctx June 25, 2024 23:36
@tsctx
Copy link
Member

tsctx commented Jun 26, 2024

it seems to lint error

test/fetch/max-listeners.js Outdated Show resolved Hide resolved
Co-authored-by: tsctx <91457664+tsctx@users.noreply.github.com>
@fawazahmed0 fawazahmed0 requested a review from tsctx June 26, 2024 12:56
Copy link
Member

@tsctx tsctx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@tsctx tsctx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tsctx tsctx merged commit 71358de into nodejs:main Jun 26, 2024
30 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
4 participants