Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: instantiation of ResponseError, pass headers and data correctly #3472

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 16, 2024

It is disputable. Maybe body should not be passed as data?

@Uzlopak Uzlopak requested review from mertcanaltin, KhafraDev, Ethan-Arrowood and ronag and removed request for mertcanaltin and Ethan-Arrowood August 16, 2024 16:27
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 1514b28 into nodejs:main Aug 17, 2024
32 checks passed
@Uzlopak Uzlopak deleted the fix-response-error-instantiation branch August 17, 2024 09:58
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants