Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: CONNECT calls onUpgrade multiple times #348

Merged
merged 4 commits into from
Aug 23, 2020
Merged

fix: CONNECT calls onUpgrade multiple times #348

merged 4 commits into from
Aug 23, 2020

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 22, 2020 •
edited
Loading

No description provided.

@ronag ronag mentioned this pull request Aug 22, 2020
Closed
17 tasks
@ronag ronag self-assigned this Aug 22, 2020
@ronag ronag force-pushed the connect-upgrade2 branch 2 times, most recently from f5fb229 to 1a17114 Compare August 22, 2020 10:34
@ronag ronag marked this pull request as ready for review August 22, 2020 11:20
@ronag ronag requested a review from mcollina August 22, 2020 11:20
@ronag

This comment has been minimized.

# to view
mcollina
mcollina approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag force-pushed the connect-upgrade2 branch from 878f312 to 3c225e2 Compare August 23, 2020 14:47
@ronag ronag merged commit 8426ab6 into master Aug 23, 2020
@ronag ronag deleted the connect-upgrade2 branch August 23, 2020 14:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees

@ronag ronag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronag @mcollina